[v3,1/4] hdat: Add 'primary' property to master chip xscom node

Submitted by Vasant Hegde on March 14, 2017, 5:01 a.m.

Details

Message ID 1489467718-10273-1-git-send-email-hegdevasant@linux.vnet.ibm.com
State New
Headers show

Commit Message

Vasant Hegde March 14, 2017, 5:01 a.m.
Needed for SBE communication as some of the SBE MBOX commands
has to be sent to master chip SBE only.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 hdata/spira.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Benjamin Herrenschmidt March 14, 2017, 6:01 a.m.
On Tue, 2017-03-14 at 10:31 +0530, Vasant Hegde wrote:
> Needed for SBE communication as some of the SBE MBOX commands
> has to be sent to master chip SBE only.

Is this well defined in HDAT that the primary chiptod is the same as
the "primary" chip/mbox ? Or did you just hack that up without asking
the HDAT/HostBoot guys ? :-)

> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> ---
>  hdata/spira.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hdata/spira.c b/hdata/spira.c
> index 512784f..362b7b2 100644
> --- a/hdata/spira.c
> +++ b/hdata/spira.c
> @@ -631,8 +631,10 @@ static void add_chiptod_node(unsigned int
> chip_id, int flags)
>  	dt_add_property_strings(node, "compatible", "ibm,power-
> chiptod",
>  			       compat_str);
>  
> -	if (flags & CHIPTOD_ID_FLAGS_PRIMARY)
> +	if (flags & CHIPTOD_ID_FLAGS_PRIMARY) {
> +		dt_add_property(xscom_node, "primary", NULL, 0);
>  		dt_add_property(node, "primary", NULL, 0);
> +	}
>  	if (flags & CHIPTOD_ID_FLAGS_SECONDARY)
>  		dt_add_property(node, "secondary", NULL, 0);
>  }

Patch hide | download patch | download mbox

diff --git a/hdata/spira.c b/hdata/spira.c
index 512784f..362b7b2 100644
--- a/hdata/spira.c
+++ b/hdata/spira.c
@@ -631,8 +631,10 @@  static void add_chiptod_node(unsigned int chip_id, int flags)
 	dt_add_property_strings(node, "compatible", "ibm,power-chiptod",
 			       compat_str);
 
-	if (flags & CHIPTOD_ID_FLAGS_PRIMARY)
+	if (flags & CHIPTOD_ID_FLAGS_PRIMARY) {
+		dt_add_property(xscom_node, "primary", NULL, 0);
 		dt_add_property(node, "primary", NULL, 0);
+	}
 	if (flags & CHIPTOD_ID_FLAGS_SECONDARY)
 		dt_add_property(node, "secondary", NULL, 0);
 }