ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2

Submitted by Rafal Milecki on March 13, 2017, 9:37 p.m.

Details

Message ID ef756112-d8a0-b7c0-1e13-29ea49ceb4c9@milecki.pl
State New
Headers show

Commit Message

Rafal Milecki March 13, 2017, 9:37 p.m.
On 03/13/2017 08:27 PM, Jon Mason wrote:
> On Mon, Mar 13, 2017 at 3:15 PM, Rafał Miłecki <rafal@milecki.pl> wrote:
>> On 03/13/2017 08:14 PM, Andrew Lunn wrote:
>>>
>>> On Mon, Mar 13, 2017 at 07:48:26PM +0100, Rafa?? Mi??ecki wrote:
>>>>
>>>> On 03/12/2017 06:10 PM, Andrew Lunn wrote:
>>>>>>
>>>>>> +       chosen {
>>>>>> +               bootargs = "console=ttyS0,115200 earlycon";
>>>>>
>>>>>
>>>>> Using bootargs to pass the serial settings has been deprecated for a
>>>>> while. Please use stdout-path instead.
>>>>
>>>>
>>>> I tried following patch with my SR400ac (I put Archer C5 aside for now).
>>>
>>>
>>> Hi Rafael
>>>
>>> Take a look at for example the bcm911360k.dts
>>>
>>>         aliases {
>>>                 serial0 = &uart3;
>>>         };
>>>
>>>         chosen {
>>>                 stdout-path = "serial0:115200n8";
>>>         };
>>>
>>> You need an alias to the serial device you want to us, and you should
>>> list the speed, parity, bits etc.
>>
>>
>> That was actually my first try (just with s/uart3/uart0) and I got the same
>> problem.
>
> I have a similar line in the bcm953012k.dts, and the serial there works for me.

Well, the serial seems to work OK (I'm getting boot log & I can see my chars
being echoed back). I just can't log in. Can this kernel change somehow affect
user space? I also tried method with alias, etc. (see below), it doesn't help,

Also since serial console works, I'm not sure if decompiling dtb will show
anything.

Comments

Andrew Lunn March 13, 2017, 10:33 p.m.
On Mon, Mar 13, 2017 at 10:37:11PM +0100, Rafa?? Mi??ecki wrote:
> On 03/13/2017 08:27 PM, Jon Mason wrote:
> >On Mon, Mar 13, 2017 at 3:15 PM, Rafa?? Mi??ecki <rafal@milecki.pl> wrote:
> >>On 03/13/2017 08:14 PM, Andrew Lunn wrote:
> >>>
> >>>On Mon, Mar 13, 2017 at 07:48:26PM +0100, Rafa?? Mi??ecki wrote:
> >>>>
> >>>>On 03/12/2017 06:10 PM, Andrew Lunn wrote:
> >>>>>>
> >>>>>>+       chosen {
> >>>>>>+               bootargs = "console=ttyS0,115200 earlycon";
> >>>>>
> >>>>>
> >>>>>Using bootargs to pass the serial settings has been deprecated for a
> >>>>>while. Please use stdout-path instead.
> >>>>
> >>>>
> >>>>I tried following patch with my SR400ac (I put Archer C5 aside for now).
> >>>
> >>>
> >>>Hi Rafael
> >>>
> >>>Take a look at for example the bcm911360k.dts
> >>>
> >>>        aliases {
> >>>                serial0 = &uart3;
> >>>        };
> >>>
> >>>        chosen {
> >>>                stdout-path = "serial0:115200n8";
> >>>        };
> >>>
> >>>You need an alias to the serial device you want to us, and you should
> >>>list the speed, parity, bits etc.
> >>
> >>
> >>That was actually my first try (just with s/uart3/uart0) and I got the same
> >>problem.
> >
> >I have a similar line in the bcm953012k.dts, and the serial there works for me.
> 
> Well, the serial seems to work OK (I'm getting boot log & I can see my chars
> being echoed back). I just can't log in. Can this kernel change somehow affect
> user space?

Yes, it can. You probably don't have a getty running on ttyS0. But you
do have on /dev/console? Look in /etc/inittab.

   Andrew

Patch hide | download patch | download mbox

diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
index 36b628b..a5442a9 100644
--- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
+++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
@@ -17,7 +17,7 @@ 
  	model = "SmartRG SR400ac";

  	chosen {
-		bootargs = "console=ttyS0,115200 earlycon";
+		bootargs = "earlycon";
  	};

  	memory {
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 4fbb089..5a9fa3e 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -18,8 +18,12 @@ 
  / {
  	interrupt-parent = <&gic>;

+	aliases {
+		serial0 = &uart0;
+	};
+
  	chosen {
-		stdout-path = &uart0;
+		stdout-path = "serial0:115200n8";
  	};

  	chipcommonA {