Patchwork [U-Boot] ARMv7: Fix linker errors across toolchain versions

login
register
mail settings
Submitter Sanjeev Premi
Date Dec. 1, 2010, 3:58 p.m.
Message ID <B85A65D85D7EB246BE421B3FB0FBB5930247AFDA69@dbde02.ent.ti.com>
Download mbox | patch
Permalink /patch/73842/
State Rejected
Headers show

Comments

Sanjeev Premi - Dec. 1, 2010, 3:58 p.m.
> -----Original Message-----
> From: Premi, Sanjeev 
> Sent: Wednesday, December 01, 2010 8:47 PM
> To: u-boot@lists.denx.de
> Cc: Premi, Sanjeev
> Subject: [PATCH] ARMv7: Fix linker errors across toolchain versions
> 
> This patch fixes the linker problems noticed while
> building the omap3_evm with Codesourcery toolchains
> 2009q1, 2009q3 and 2010q1.
> 
> The compilation was tested as success for both
> omap3_evm and omap3_beagle with toolchain versions
> 2009q1 and 2010q1.
> 
>  [1] http://marc.info/?l=u-boot&m=129104332808386&w=2
> 
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
> The patch touches all ARMv7 architectures, will need
> to be reviewed thoroughly.
> 
> I am getting hang of relocation feature, but definitely
> hands-on. Impact would have to be reviewd as well.
> This is the reason for sending the patch early - before
> i start testing on the evm.
> 
>  arch/arm/cpu/armv7/u-boot.lds |   26 +++++++++++++++-----------
>  1 files changed, 15 insertions(+), 11 deletions(-)
> 
[snip]...[snip]

The u-boot built after this change alone gets stuck somewhere after
dram_init(). However, removing the "sort" from LIBS (as suggested
by Wolfgang), the u-boot comes up fine on the omap3_evm.

[patch]
[/patch]


U-Boot 2010.12-rc2-00030-g4998cdc-dirty (Dec 01 2010 - 21:09:59)

OMAP3530-GP ES3.1, CPU-OPP2, L3-165MHz, Max CPU Clock 720 mHz
OMAP3 EVM board + LPDDR/NAND
I2C:   ready
DRAM:  256 MiB
NAND:  256 MiB
In:    serial
Out:   serial
Err:   serial
Read back SMSC id 0x92200000
Die ID #609200040000000004032d460c01201a
Net:   smc911x-0
Hit any key to stop autoboot:  0
OMAP3_EVM #
OMAP3_EVM #


Here is my git-log (including the patch above):
premi # g-log-10
4998cdc : ARMv7: Fix linker errors across toolchain versions
49733aa : Merge branch 'master' of /home/wd/git/u-boot/custodians
f8264e0 : Merge branch 'master' of git://git.denx.de/u-boot-arm
b194577 : hwconfig: Fix dummy initialization of {board, cpu}_hwconfig
a55bb83 : powerpc/85xx: Introduce CONFIG_SYS_EXTRA_ENV_RELOC
52eb2c7 : Merge branch 'master' of git://git.denx.de/u-boot-samsung
83b622a : Merge branch 'master' of /home/wd/git/u-boot/custodians
3410a99 : Merge branch 'master' of git://git.denx.de/u-boot-sh
a7bf3ec : Merge branch 'master' of /home/wd/git/u-boot/custodians
e45c98a : mpc83xx: Make it boot again
premi #
Wolfgang Denk - Dec. 1, 2010, 7:55 p.m.
Dear "Premi, Sanjeev",

In message <B85A65D85D7EB246BE421B3FB0FBB5930247AFDA69@dbde02.ent.ti.com> you wrote:
>
> The u-boot built after this change alone gets stuck somewhere after
> dram_init(). However, removing the "sort" from LIBS (as suggested
> by Wolfgang), the u-boot comes up fine on the omap3_evm.

I did NOT suggest that. This was just intended as debug hint.  We do
need this sort.

Best regards,

Wolfgang Denk

Patch

diff --git a/Makefile b/Makefile
index 87a383d..a530261 100644
--- a/Makefile
+++ b/Makefile
@@ -263,7 +263,7 @@  ifeq ($(SOC),s5pc2xx)
 LIBS += $(CPUDIR)/s5p-common/libs5p-common.o
 endif

-LIBS := $(addprefix $(obj),$(sort $(LIBS)))
+LIBS := $(addprefix $(obj),$(LIBS))
 .PHONY : $(LIBS) $(TIMESTAMP_FILE) $(VERSION_FILE)

 LIBBOARD = board/$(BOARDDIR)/lib$(BOARD).o