From patchwork Wed Dec 1 14:45:52 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 73824 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EF5C0B6F14 for ; Thu, 2 Dec 2010 01:45:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484Ab0LAOp4 (ORCPT ); Wed, 1 Dec 2010 09:45:56 -0500 Received: from hera.kernel.org ([140.211.167.34]:56215 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950Ab0LAOp4 (ORCPT ); Wed, 1 Dec 2010 09:45:56 -0500 Received: from htj.dyndns.org (localhost [127.0.0.1]) by hera.kernel.org (8.14.4/8.14.3) with ESMTP id oB1EjrBr016225; Wed, 1 Dec 2010 14:45:54 GMT X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.96.1 at hera.kernel.org Received: from [127.0.0.2] (htj.dyndns.org [127.0.0.2]) by htj.dyndns.org (Postfix) with ESMTPSA id E85182FA2FE8; Wed, 1 Dec 2010 15:45:52 +0100 (CET) Message-ID: <4CF65FA0.5050903@kernel.org> Date: Wed, 01 Dec 2010 15:45:52 +0100 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: Antonio Toma CC: linux-ide@vger.kernel.org Subject: Re: Regression between 2.6.34 and 2.6.35 ? References: <4CEFC051.7090800@kernel.org> <4CF3CE68.2020500@kernel.org> In-Reply-To: X-Enigmail-Version: 1.1.1 X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on hera.kernel.org X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Wed, 01 Dec 2010 14:45:54 +0000 (UTC) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hello, On 11/30/2010 07:53 PM, Antonio Toma wrote: > here is usual information (interrupts and boot logs) after compiling > and installing 2.6.36.1 > The issue is still there. > Please, let me know how to patch for further debugging. Can you please apply the following patch, see whether the behavior changes and report the kernel log? Thanks. --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index d05387d..b8bc453 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -1532,11 +1532,10 @@ static unsigned int __ata_sff_port_intr(struct ata_port *ap, if (!(qc->dev->flags & ATA_DFLAG_CDB_INTR)) return ata_sff_idle_irq(ap); break; - case HSM_ST: - case HSM_ST_LAST: - break; - default: + case HSM_ST_IDLE: return ata_sff_idle_irq(ap); + default: + break; } /* check main status, clearing INTRQ if needed */ @@ -2821,7 +2820,7 @@ unsigned int ata_bmdma_port_intr(struct ata_port *ap, struct ata_queued_cmd *qc) VPRINTK("ata%u: host_stat 0x%X\n", ap->print_id, host_stat); /* if it's not our irq... */ - if (!(host_stat & ATA_DMA_INTR)) + if (!(host_stat & (ATA_DMA_INTR | ATA_DMA_ERR))) return ata_sff_idle_irq(ap); /* before we do anything else, clear DMA-Start bit */ @@ -2830,6 +2829,7 @@ unsigned int ata_bmdma_port_intr(struct ata_port *ap, struct ata_queued_cmd *qc) if (unlikely(host_stat & ATA_DMA_ERR)) { /* error when transfering data to/from memory */ + ata_port_printk(ap, KERN_WARNING, "XXX AC_ERR_HOST_BUS\n"); qc->err_mask |= AC_ERR_HOST_BUS; ap->hsm_task_state = HSM_ST_ERR; }