Patchwork [libgomp,testsuite] Double libgomp.fortran/vla8.f90 timeout factor

login
register
mail settings
Submitter Rainer Orth
Date Dec. 1, 2010, 1:33 p.m.
Message ID <yddd3pl39ez.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/73820/
State New
Headers show

Comments

Rainer Orth - Dec. 1, 2010, 1:33 p.m.
The libgomp.fortran/vla8.f90 compilation times out for me on many
platforms.  E.g. on an 250 MHz R10k Onyx^2 running IRIX 6.5 ,
compilation takes between 2:30 and 3 minutes, so for a parallel make
check it can easily exceed the default 5 minutes (300 s) timeout.

The following patch works around this by doubling the timeout and allows
all libgomp tests to succeed on mips-sgi-irix6.5.  Another option would
be to declare the test as expensive (dg-require-effective-target
run_expensive_tests) and not run it by default.

Whatever solution is chosen, something needs to be done here.

Is the following patch ok for mainline (and the 4.4 and 4.5 branches
after testing)?

Thanks.
	Rainer


2010-12-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* testsuite/libgomp.fortran/vla8.f90: Use dg-timeout-factor 2.0.
Jakub Jelinek - Dec. 1, 2010, 1:37 p.m.
On Wed, Dec 01, 2010 at 02:33:08PM +0100, Rainer Orth wrote:
> 2010-12-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	* testsuite/libgomp.fortran/vla8.f90: Use dg-timeout-factor 2.0.

Ok.

> --- a/libgomp/testsuite/libgomp.fortran/vla8.f90	Wed Dec 01 13:33:36 2010 +0100
> +++ b/libgomp/testsuite/libgomp.fortran/vla8.f90	Wed Dec 01 13:35:01 2010 +0100
> @@ -1,4 +1,5 @@
>  ! { dg-do run }
> +! { dg-timeout-factor 2.0 }
>  
>    call test
>  contains

	Jakub

Patch

diff -r 88e4219a8dd3 libgomp/testsuite/libgomp.fortran/vla8.f90
--- a/libgomp/testsuite/libgomp.fortran/vla8.f90	Wed Dec 01 13:33:36 2010 +0100
+++ b/libgomp/testsuite/libgomp.fortran/vla8.f90	Wed Dec 01 13:35:01 2010 +0100
@@ -1,4 +1,5 @@ 
 ! { dg-do run }
+! { dg-timeout-factor 2.0 }
 
   call test
 contains