| Message ID | 20170313132753.7178-1-Vincent.Riera@imgtec.com |
|---|---|
| State | Superseded |
| Headers | show |
Hello, On Mon, 13 Mar 2017 13:27:53 +0000, Vicente Olivert Riera wrote: > -config BR2_PACKAGE_SYSTEMD_KDBUS > - bool "enable kdbus support" > - help > - Enable kdbus support for Systemd. This removes a Config.in option, so there is a question: * If kdbus support is now unconditionally compiled into systemd, then I believe we don't need a Config.in.legacy option, because people who had it enabled would still have kdbus support. * If kdbus support has been dropped entirely from systemd, then perhaps a Config.in.legacy entry should be added to warn users. CC'ing Arnout on this. Best regards, Thomas
Hello, On 03/18/2017 03:56 PM, Thomas Petazzoni wrote: > Hello, > > On Mon, 13 Mar 2017 13:27:53 +0000, Vicente Olivert Riera wrote: > >> -config BR2_PACKAGE_SYSTEMD_KDBUS >> - bool "enable kdbus support" >> - help >> - Enable kdbus support for Systemd. > > This removes a Config.in option, so there is a question: > > * If kdbus support is now unconditionally compiled into systemd, then > I believe we don't need a Config.in.legacy option, because people > who had it enabled would still have kdbus support. > > * If kdbus support has been dropped entirely from systemd, then > perhaps a Config.in.legacy entry should be added to warn users. I'm pretty sure kdbus has been dropped. It didn't get into the kernel. The successor project seems to be https://github.com/bus1. Kind regards, Marcus > > CC'ing Arnout on this. > > Best regards, > > Thomas >
On 18-03-17 16:02, Marcus Hoffmann wrote: > Hello, > > On 03/18/2017 03:56 PM, Thomas Petazzoni wrote: >> Hello, >> >> On Mon, 13 Mar 2017 13:27:53 +0000, Vicente Olivert Riera wrote: >> >>> -config BR2_PACKAGE_SYSTEMD_KDBUS >>> - bool "enable kdbus support" >>> - help >>> - Enable kdbus support for Systemd. >> >> This removes a Config.in option, so there is a question: >> >> * If kdbus support is now unconditionally compiled into systemd, then >> I believe we don't need a Config.in.legacy option, because people >> who had it enabled would still have kdbus support. >> >> * If kdbus support has been dropped entirely from systemd, then >> perhaps a Config.in.legacy entry should be added to warn users. > > > I'm pretty sure kdbus has been dropped. It didn't get into the kernel. > The successor project seems to be https://github.com/bus1. Yes, it should get a Config.in.legacy entry. Regards, Arnout
diff --git a/package/systemd/Config.in b/package/systemd/Config.in index aaed7dc..0f54686 100644 --- a/package/systemd/Config.in +++ b/package/systemd/Config.in @@ -155,11 +155,6 @@ config BR2_PACKAGE_SYSTEMD_IMPORTD http://www.freedesktop.org/software/systemd/man/machinectl.html#Image%20Transfer%20Commands -config BR2_PACKAGE_SYSTEMD_KDBUS - bool "enable kdbus support" - help - Enable kdbus support for Systemd. - config BR2_PACKAGE_SYSTEMD_LOCALED bool "enable locale daemon" help diff --git a/package/systemd/systemd.hash b/package/systemd/systemd.hash index 0acaa3c..17f4c0f 100644 --- a/package/systemd/systemd.hash +++ b/package/systemd/systemd.hash @@ -1,2 +1,2 @@ # sha256 locally computed -sha256 1172c7c7d5d72fbded53186e7599d5272231f04cc8b72f9a0fb2c5c20dfc4880 systemd-232.tar.gz +sha256 8b3e99da3d4164b66581830a7f2436c0c8fe697b5fbdc3927bdb960646be0083 systemd-233.tar.gz diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk index 0d2f416..cfd885d 100644 --- a/package/systemd/systemd.mk +++ b/package/systemd/systemd.mk @@ -4,7 +4,7 @@ # ################################################################################ -SYSTEMD_VERSION = 232 +SYSTEMD_VERSION = 233 SYSTEMD_SITE = $(call github,systemd,systemd,v$(SYSTEMD_VERSION)) SYSTEMD_LICENSE = LGPLv2.1+, GPLv2+ (udev), Public Domain (few source files, see README) SYSTEMD_LICENSE_FILES = LICENSE.GPL2 LICENSE.LGPL2.1 README @@ -87,12 +87,6 @@ else SYSTEMD_CONF_OPTS += --disable-xkbcommon endif -ifeq ($(BR2_PACKAGE_SYSTEMD_KDBUS),y) -SYSTEMD_CONF_OPTS += --enable-kdbus -else -SYSTEMD_CONF_OPTS += --disable-kdbus -endif - ifeq ($(BR2_PACKAGE_BZIP2),y) SYSTEMD_DEPENDENCIES += bzip2 SYSTEMD_CONF_OPTS += --enable-bzip2
--disable-kdbus no longer exists, so remove everything related to it. Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- package/systemd/Config.in | 5 ----- package/systemd/systemd.hash | 2 +- package/systemd/systemd.mk | 8 +------- 3 files changed, 2 insertions(+), 13 deletions(-)