From patchwork Tue Nov 30 14:35:59 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 73798 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7E25CB7080 for ; Wed, 1 Dec 2010 22:30:07 +1100 (EST) Received: from localhost ([127.0.0.1]:48814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNksu-0005S5-6A for incoming@patchwork.ozlabs.org; Wed, 01 Dec 2010 06:30:04 -0500 Received: from [140.186.70.92] (port=42875 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNeVG-0006LE-Tb for qemu-devel@nongnu.org; Tue, 30 Nov 2010 23:41:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNRJt-0002P3-Gq for qemu-devel@nongnu.org; Tue, 30 Nov 2010 09:36:38 -0500 Received: from cantor.suse.de ([195.135.220.2]:55585 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNRJt-0001JW-Ay for qemu-devel@nongnu.org; Tue, 30 Nov 2010 09:36:37 -0500 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 98096945D8; Tue, 30 Nov 2010 15:36:02 +0100 (CET) From: Alexander Graf To: QEMU-devel Developers Date: Tue, 30 Nov 2010 15:35:59 +0100 Message-Id: <1291127761-16501-14-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1291127761-16501-1-git-send-email-agraf@suse.de> References: <1291127761-16501-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: Blue Swirl , Paul Brook Subject: [Qemu-devel] [PATCH 13/15] heathrow_pic: Declare as little endian X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch replaces explicit bswaps with endianness hints to the mmio layer. Signed-off-by: Alexander Graf --- hw/heathrow_pic.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/heathrow_pic.c b/hw/heathrow_pic.c index 390b63c..b19b754 100644 --- a/hw/heathrow_pic.c +++ b/hw/heathrow_pic.c @@ -68,7 +68,6 @@ static void pic_writel (void *opaque, target_phys_addr_t addr, uint32_t value) HeathrowPIC *pic; unsigned int n; - value = bswap32(value); n = ((addr & 0xfff) - 0x10) >> 4; PIC_DPRINTF("writel: " TARGET_FMT_plx " %u: %08x\n", addr, n, value); if (n >= 2) @@ -118,7 +117,6 @@ static uint32_t pic_readl (void *opaque, target_phys_addr_t addr) } } PIC_DPRINTF("readl: " TARGET_FMT_plx " %u: %08x\n", addr, n, value); - value = bswap32(value); return value; } @@ -223,7 +221,7 @@ qemu_irq *heathrow_pic_init(int *pmem_index, /* only 1 CPU */ s->irqs = irqs[0]; *pmem_index = cpu_register_io_memory(pic_read, pic_write, s, - DEVICE_NATIVE_ENDIAN); + DEVICE_LITTLE_ENDIAN); register_savevm(NULL, "heathrow_pic", -1, 1, heathrow_pic_save, heathrow_pic_load, s);