Patchwork [13/15] heathrow_pic: Declare as little endian

login
register
mail settings
Submitter Alexander Graf
Date Nov. 30, 2010, 2:35 p.m.
Message ID <1291127761-16501-14-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/73798/
State New
Headers show

Comments

Alexander Graf - Nov. 30, 2010, 2:35 p.m.
This patch replaces explicit bswaps with endianness hints to the
mmio layer.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 hw/heathrow_pic.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Patch

diff --git a/hw/heathrow_pic.c b/hw/heathrow_pic.c
index 390b63c..b19b754 100644
--- a/hw/heathrow_pic.c
+++ b/hw/heathrow_pic.c
@@ -68,7 +68,6 @@  static void pic_writel (void *opaque, target_phys_addr_t addr, uint32_t value)
     HeathrowPIC *pic;
     unsigned int n;
 
-    value = bswap32(value);
     n = ((addr & 0xfff) - 0x10) >> 4;
     PIC_DPRINTF("writel: " TARGET_FMT_plx " %u: %08x\n", addr, n, value);
     if (n >= 2)
@@ -118,7 +117,6 @@  static uint32_t pic_readl (void *opaque, target_phys_addr_t addr)
         }
     }
     PIC_DPRINTF("readl: " TARGET_FMT_plx " %u: %08x\n", addr, n, value);
-    value = bswap32(value);
     return value;
 }
 
@@ -223,7 +221,7 @@  qemu_irq *heathrow_pic_init(int *pmem_index,
     /* only 1 CPU */
     s->irqs = irqs[0];
     *pmem_index = cpu_register_io_memory(pic_read, pic_write, s,
-                                         DEVICE_NATIVE_ENDIAN);
+                                         DEVICE_LITTLE_ENDIAN);
 
     register_savevm(NULL, "heathrow_pic", -1, 1, heathrow_pic_save,
                     heathrow_pic_load, s);