Patchwork [14/16] ide: Set bus master inactive on error

login
register
mail settings
Submitter Kevin Wolf
Date Nov. 30, 2010, 5:58 p.m.
Message ID <1291139900-20329-15-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/73767/
State New
Headers show

Comments

Kevin Wolf - Nov. 30, 2010, 5:58 p.m.
BMIDEA in the status register must be cleared on error. This makes FreeBSD
respond (more) correctly to I/O errors.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/ide/core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Patch

diff --git a/hw/ide/core.c b/hw/ide/core.c
index 7136ade..430350f 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -486,6 +486,8 @@  void ide_dma_error(IDEState *s)
     ide_transfer_stop(s);
     s->error = ABRT_ERR;
     s->status = READY_STAT | ERR_STAT;
+    ide_dma_set_inactive(s->bus->bmdma);
+    s->bus->bmdma->status |= BM_STATUS_INT;
     ide_set_irq(s->bus);
 }