| Message ID | 20170310200550.13313-2-krzk@kernel.org |
|---|---|
| State | New |
| Headers | show |
On Fri, Mar 10, 2017 at 10:05:49PM +0200, Krzysztof Kozlowski wrote: > The 'value' argument is not modified so this can be made const for code > safeness. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Unless another maintainer wants to take this, I am queueing it for 2.10 on my machine-next branch. > --- > hw/core/qdev-properties.c | 3 ++- > include/hw/qdev-properties.h | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > index 6ab4265eb478..fa3617db2df1 100644 > --- a/hw/core/qdev-properties.c > +++ b/hw/core/qdev-properties.c > @@ -1010,7 +1010,8 @@ void qdev_prop_set_string(DeviceState *dev, const char *name, const char *value) > object_property_set_str(OBJECT(dev), value, name, &error_abort); > } > > -void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value) > +void qdev_prop_set_macaddr(DeviceState *dev, const char *name, > + const uint8_t *value) > { > char str[2 * 6 + 5 + 1]; > snprintf(str, sizeof(str), "%02x:%02x:%02x:%02x:%02x:%02x", > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h > index 7ac315331aa0..1d69fa7a8f04 100644 > --- a/include/hw/qdev-properties.h > +++ b/include/hw/qdev-properties.h > @@ -188,7 +188,8 @@ void qdev_prop_set_chr(DeviceState *dev, const char *name, Chardev *value); > void qdev_prop_set_netdev(DeviceState *dev, const char *name, NetClientState *value); > void qdev_prop_set_drive(DeviceState *dev, const char *name, > BlockBackend *value, Error **errp); > -void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value); > +void qdev_prop_set_macaddr(DeviceState *dev, const char *name, > + const uint8_t *value); > void qdev_prop_set_enum(DeviceState *dev, const char *name, int value); > /* FIXME: Remove opaque pointer properties. */ > void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value); > -- > 2.9.3 >
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 6ab4265eb478..fa3617db2df1 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -1010,7 +1010,8 @@ void qdev_prop_set_string(DeviceState *dev, const char *name, const char *value) object_property_set_str(OBJECT(dev), value, name, &error_abort); } -void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value) +void qdev_prop_set_macaddr(DeviceState *dev, const char *name, + const uint8_t *value) { char str[2 * 6 + 5 + 1]; snprintf(str, sizeof(str), "%02x:%02x:%02x:%02x:%02x:%02x", diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h index 7ac315331aa0..1d69fa7a8f04 100644 --- a/include/hw/qdev-properties.h +++ b/include/hw/qdev-properties.h @@ -188,7 +188,8 @@ void qdev_prop_set_chr(DeviceState *dev, const char *name, Chardev *value); void qdev_prop_set_netdev(DeviceState *dev, const char *name, NetClientState *value); void qdev_prop_set_drive(DeviceState *dev, const char *name, BlockBackend *value, Error **errp); -void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value); +void qdev_prop_set_macaddr(DeviceState *dev, const char *name, + const uint8_t *value); void qdev_prop_set_enum(DeviceState *dev, const char *name, int value); /* FIXME: Remove opaque pointer properties. */ void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value);
The 'value' argument is not modified so this can be made const for code safeness. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- hw/core/qdev-properties.c | 3 ++- include/hw/qdev-properties.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)