diff mbox

[PING,6] Remove xfail from thread_local-order2.C.

Message ID 9b57331b-b6db-6a89-7672-12f72c8eacce@foss.arm.com
State New
Headers show

Commit Message

Jiong Wang March 10, 2017, 4:22 p.m. UTC 
On 07/02/17 16:01, Mike Stump wrote:
> On Feb 7, 2017, at 2:20 AM, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
>> No.  In fact, I'd go for something like this:
>>
>> 2017-02-07  Dominik Vogt  <vogt@linux.vnet.ibm.com>
>> 	    Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>>
>> 	* g++.dg/tls/thread_local-order2.C: Only xfail execution on
>> 	*-*-solaris*.
>>
>> # HG changeset patch
>> # Parent  031bb7a327cc984d387a8ae64e7c65d4b8793731
>> Only xfail g++.dg/tls/thread_local-order2.C on Solaris
>>
>> diff --git a/gcc/testsuite/g++.dg/tls/thread_local-order2.C b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
>> --- a/gcc/testsuite/g++.dg/tls/thread_local-order2.C
>> +++ b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
>> @@ -2,10 +2,11 @@
>> // that isn't reverse order of construction.  We need to move
>> // __cxa_thread_atexit into glibc to get this right.
>>
>> -// { dg-do run { xfail *-*-* } }
>> +// { dg-do run }
>> // { dg-require-effective-target c++11 }
>> // { dg-add-options tls }
>> // { dg-require-effective-target tls_runtime }
>> +// { dg-xfail-run-if "" { *-*-solaris* } }
>>
>> extern "C" void abort();
>> extern "C" int printf (const char *, ...);
>>
>> This way one can easily add per-target PR references or explanations,
>> e.g. for darwin10 or others should they come up.
>>
>> Tested on i386-pc-solaris2.12 and x86_64-pc-linux-gnu.  Ok for mainline?
> Ok.
>
> I think that addresses most all known issues.  I'll pre-appove any additional targets people find as trivial.  For example, if darwin10 doesn't pass, then *-*-darwin10* would be fine to add if that fixes the issue.  I don't happen to have one that old to just test on.

I am seeing this failure on arm and aarch64 bare-metal environment where newlib are used.

This patch also XFAIL this testcase on newlib.

OK for trunk?

Regards,
Jiong

gcc/testsuite/
2017-03-10  Jiong Wang  <jiong.wang@arm.com>

         * g++.dg/tls/thread_local-order2.C: XFAIL on newlib.

Comments

Mike Stump March 10, 2017, 5:28 p.m. UTC | #1 
On Mar 10, 2017, at 8:22 AM, Jiong Wang <jiong.wang@foss.arm.com> wrote:
> 
> I am seeing this failure on arm and aarch64 bare-metal environment where newlib are used.
> 
> This patch also XFAIL this testcase on newlib.
> 
> OK for trunk?

That's fine, if you want.  The other solution is to actually fix newlib, which would be a better solution, if you have the time.
diff mbox

Patch

diff --git a/gcc/testsuite/g++.dg/tls/thread_local-order2.C b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
index 3cbd257b5fab05d9af7aeceb4f97e9a79d2a283e..d274e8c606542893f8a792469e075056793335ea 100644
--- a/gcc/testsuite/g++.dg/tls/thread_local-order2.C
+++ b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
@@ -6,7 +6,7 @@ 
 // { dg-require-effective-target c++11 }
 // { dg-add-options tls }
 // { dg-require-effective-target tls_runtime }
-// { dg-xfail-run-if "" { hppa*-*-hpux* *-*-solaris* } }
+// { dg-xfail-run-if "" { { hppa*-*-hpux* *-*-solaris* } || { newlib } } }
 
 extern "C" void abort();
 extern "C" int printf (const char *, ...);