[2/2,v2] new package: redland

Submitted by Erwan Gautron on March 9, 2017, 7:36 a.m.

Details

Message ID 1489044989-4047-2-git-send-email-erwan.gautron@yahoo.fr
State Changes Requested
Headers show

Commit Message

Erwan Gautron March 9, 2017, 7:36 a.m.
Signed-off-by: Erwan Gautron <erwan.gautron@yahoo.fr>

	  Redland is a set of free software C libraries
	  that provide support for the
	  Resource Description Framework (RDF).
	  http://librdf.org/

Signed-off-by: Erwan Gautron <erwan.gautron@yahoo.fr>
---
 DEVELOPERS                 |  1 +
 package/Config.in          |  1 +
 package/redland/Config.in  |  9 +++++++++
 package/redland/redland.mk | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100755 package/redland/Config.in
 create mode 100755 package/redland/redland.mk

Comments

Romain Naour April 17, 2017, 11:55 a.m.
Hi Erwan,

Le 09/03/2017 à 08:36, Erwan Gautron a écrit :
> Signed-off-by: Erwan Gautron <erwan.gautron@yahoo.fr>
> 
> 	  Redland is a set of free software C libraries
> 	  that provide support for the
> 	  Resource Description Framework (RDF).
> 	  http://librdf.org/

Same recommendation than for rasqal package.

> 
> Signed-off-by: Erwan Gautron <erwan.gautron@yahoo.fr>
> ---
>  DEVELOPERS                 |  1 +
>  package/Config.in          |  1 +
>  package/redland/Config.in  |  9 +++++++++
>  package/redland/redland.mk | 15 +++++++++++++++
>  4 files changed, 26 insertions(+)
>  create mode 100755 package/redland/Config.in
>  create mode 100755 package/redland/redland.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index afcf983..460c71a 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -465,6 +465,7 @@ F:	package/szip/
>  
>  N:	Erwan Gautron <erwan.gautron@yahoo.fr>
>  F:	package/rasqal/
> +F:	package/redland/
>  
>  N:	Evan Zelkowitz <evan.zelkowitz@gmail.com>
>  F:	package/sdl_gfx/
> diff --git a/package/Config.in b/package/Config.in
> index d46758d..541af9d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1161,6 +1161,7 @@ menu "JSON/XML"
>  	source "package/rapidxml/Config.in"
>  	source "package/raptor/Config.in"
>  	source "package/rasqal/Config.in"
> +	source "package/redland/Config.in"
>  	source "package/tinyxml/Config.in"
>  	source "package/tinyxml2/Config.in"
>  	source "package/valijson/Config.in"
> diff --git a/package/redland/Config.in b/package/redland/Config.in
> new file mode 100755
> index 0000000..cd0a41f
> --- /dev/null
> +++ b/package/redland/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_REDLAND
> +	bool "Redland RDF Libraries"
> +	select BR2_PACKAGE_RASQAL
> +

Remove empty line here.

> +	help
> +	  Redland is a set of free software C libraries
> +	  that provide support for the 
> +	  Resource Description Framework (RDF).

Add a new line between the help text and the upstream URL.

> +	  http://librdf.org/
> diff --git a/package/redland/redland.mk b/package/redland/redland.mk
> new file mode 100755
> index 0000000..ab43efb
> --- /dev/null
> +++ b/package/redland/redland.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# redland
> +#
> +################################################################################

Add a new line here.

> +REDLAND_VERSION = 1.0.17
> +REDLAND_SITE = http://download.librdf.org/source
> +REDLAND_DEPENDENCIES = rasqal

I tried to build redland but the build fail again due to incorrect include path:
 ERROR: unsafe header/library path used in cross-compilation: '-I/usr/include'

Can you check that?
It seems related to Oracle Berkeley DB (BR2_PACKAGE_BERKELEYDB) dependency which
is not handled here.
Try with --with-bdb=$(STAGING_DIR)/usr

> +REDLAND_LICENSE = GPLv2+ or LGPLv2.1+ or Apache-2.0+

It should be:
GPL-2.0 or LGPL-2.1+ or Apache-2.0

> +REDLAND_LICENSE_FILES = LICENSE.txt

Also add LICENSE-2.0.txt

> +
> +REDLAND_AUTORECONF = YES

Add a comment about autoreconf.

I'll mark your patch "Changes Requested" in patchwork, can you resend it after
taking into account all comments ?

Best regards,
Romain

> +REDLAND_INSTALL_STAGING = YES
> +
> +$(eval $(autotools-package))
>

Patch hide | download patch | download mbox

diff --git a/DEVELOPERS b/DEVELOPERS
index afcf983..460c71a 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -465,6 +465,7 @@  F:	package/szip/
 
 N:	Erwan Gautron <erwan.gautron@yahoo.fr>
 F:	package/rasqal/
+F:	package/redland/
 
 N:	Evan Zelkowitz <evan.zelkowitz@gmail.com>
 F:	package/sdl_gfx/
diff --git a/package/Config.in b/package/Config.in
index d46758d..541af9d 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1161,6 +1161,7 @@  menu "JSON/XML"
 	source "package/rapidxml/Config.in"
 	source "package/raptor/Config.in"
 	source "package/rasqal/Config.in"
+	source "package/redland/Config.in"
 	source "package/tinyxml/Config.in"
 	source "package/tinyxml2/Config.in"
 	source "package/valijson/Config.in"
diff --git a/package/redland/Config.in b/package/redland/Config.in
new file mode 100755
index 0000000..cd0a41f
--- /dev/null
+++ b/package/redland/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_REDLAND
+	bool "Redland RDF Libraries"
+	select BR2_PACKAGE_RASQAL
+
+	help
+	  Redland is a set of free software C libraries
+	  that provide support for the 
+	  Resource Description Framework (RDF).
+	  http://librdf.org/
diff --git a/package/redland/redland.mk b/package/redland/redland.mk
new file mode 100755
index 0000000..ab43efb
--- /dev/null
+++ b/package/redland/redland.mk
@@ -0,0 +1,15 @@ 
+################################################################################
+#
+# redland
+#
+################################################################################
+REDLAND_VERSION = 1.0.17
+REDLAND_SITE = http://download.librdf.org/source
+REDLAND_DEPENDENCIES = rasqal
+REDLAND_LICENSE = GPLv2+ or LGPLv2.1+ or Apache-2.0+
+REDLAND_LICENSE_FILES = LICENSE.txt
+
+REDLAND_AUTORECONF = YES
+REDLAND_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))