[1/2] ARM: dts: BCM53573: Don't use nonexistent "default-off" LED trigger

Submitted by Rafał Miłecki on March 8, 2017, 6:41 a.m.

Details

Message ID 20170308064105.26619-1-zajec5@gmail.com
State New
Headers show

Commit Message

Rafał Miłecki March 8, 2017, 6:41 a.m.
From: Rafał Miłecki <rafal@milecki.pl>

Such a trigger doesn't exist in Linux and is not needed as LED is being
turned off by default. This could cause errors in LEDs core code when
trying to set default trigger.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm/boot/dts/bcm47189-tenda-ac9.dts | 4 ----
 1 file changed, 4 deletions(-)

Comments

Pavel Machek March 8, 2017, 10:20 a.m.
On Wed 2017-03-08 07:41:04, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Such a trigger doesn't exist in Linux and is not needed as LED is being
> turned off by default. This could cause errors in LEDs core code when
> trying to set default trigger.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

For both patches:

Acked-by: Pavel Machek <pavel@ucw.cz>
Florian Fainelli March 8, 2017, 5:31 p.m.
On 03/07/2017 10:41 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Such a trigger doesn't exist in Linux and is not needed as LED is being
> turned off by default. This could cause errors in LEDs core code when
> trying to set default trigger.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Since you are fixing something, what's the proper Fixes: tag for this
commit? Likewise for the second patch.

Thanks

> ---
>  arch/arm/boot/dts/bcm47189-tenda-ac9.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm47189-tenda-ac9.dts b/arch/arm/boot/dts/bcm47189-tenda-ac9.dts
> index 6bdd79567cbd..34417dac1cd0 100644
> --- a/arch/arm/boot/dts/bcm47189-tenda-ac9.dts
> +++ b/arch/arm/boot/dts/bcm47189-tenda-ac9.dts
> @@ -26,19 +26,16 @@
>  		usb {
>  			label = "bcm53xx:blue:usb";
>  			gpios = <&chipcommon 1 GPIO_ACTIVE_HIGH>;
> -			linux,default-trigger = "default-off";
>  		};
>  
>  		wps {
>  			label = "bcm53xx:blue:wps";
>  			gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
> -			linux,default-trigger = "default-off";
>  		};
>  
>  		5ghz {
>  			label = "bcm53xx:blue:5ghz";
>  			gpios = <&chipcommon 11 GPIO_ACTIVE_HIGH>;
> -			linux,default-trigger = "default-off";
>  		};
>  
>  		system {
> @@ -54,7 +51,6 @@
>  		2ghz {
>  			label = "bcm53xx:blue:2ghz";
>  			gpios = <&pcie0_chipcommon 3 GPIO_ACTIVE_HIGH>;
> -			linux,default-trigger = "default-off";
>  		};
>  	};
>  
>
Rafał Miłecki March 8, 2017, 10:20 p.m.
On 8 March 2017 at 18:31, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 03/07/2017 10:41 PM, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> Such a trigger doesn't exist in Linux and is not needed as LED is being
>> turned off by default. This could cause errors in LEDs core code when
>> trying to set default trigger.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>
> Since you are fixing something, what's the proper Fixes: tag for this
> commit? Likewise for the second patch.

This problem was exposed by the commit f363a870eaef ("leds: core: use
deferred probing if default trigger isn't available yet") pushed to
the:
https://git.kernel.org/cgit/linux/kernel/git/j.anaszewski/linux-leds.git/log/?h=for-next

I reported problems caused by this commit in e-mail thread
New problems after f363a870eaef ("leds: core: use deferred probing if
default trigger isn't available yet")
(I can't access linux-leds archive) and it was dropped after my report.

So there is nothing to point in the "Fixes:".
Florian Fainelli March 9, 2017, 8:33 p.m.
On 03/07/2017 10:41 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Such a trigger doesn't exist in Linux and is not needed as LED is being
> turned off by default. This could cause errors in LEDs core code when
> trying to set default trigger.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied, thanks!
Pavel Machek March 10, 2017, 1:20 p.m.
On Wed 2017-03-08 09:31:44, Florian Fainelli wrote:
> On 03/07/2017 10:41 PM, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> > 
> > Such a trigger doesn't exist in Linux and is not needed as LED is being
> > turned off by default. This could cause errors in LEDs core code when
> > trying to set default trigger.
> > 
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> Since you are fixing something, what's the proper Fixes: tag for this
> commit? Likewise for the second patch.

Lets not make submitting patches any harder than it already is.
									Pavel
Florian Fainelli March 10, 2017, 5:44 p.m.
On 03/10/2017 05:20 AM, Pavel Machek wrote:
> On Wed 2017-03-08 09:31:44, Florian Fainelli wrote:
>> On 03/07/2017 10:41 PM, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> Such a trigger doesn't exist in Linux and is not needed as LED is being
>>> turned off by default. This could cause errors in LEDs core code when
>>> trying to set default trigger.
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> Since you are fixing something, what's the proper Fixes: tag for this
>> commit? Likewise for the second patch.
> 
> Lets not make submitting patches any harder than it already is.

If it was fixing something that was already in Linus' tree, it's
important to know so I can queue the patch for the appropriate pull
request targeting e.g: v4.11-rcX, this is not needed here as Rafal later
indicated.

Patch hide | download patch | download mbox

diff --git a/arch/arm/boot/dts/bcm47189-tenda-ac9.dts b/arch/arm/boot/dts/bcm47189-tenda-ac9.dts
index 6bdd79567cbd..34417dac1cd0 100644
--- a/arch/arm/boot/dts/bcm47189-tenda-ac9.dts
+++ b/arch/arm/boot/dts/bcm47189-tenda-ac9.dts
@@ -26,19 +26,16 @@ 
 		usb {
 			label = "bcm53xx:blue:usb";
 			gpios = <&chipcommon 1 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "default-off";
 		};
 
 		wps {
 			label = "bcm53xx:blue:wps";
 			gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "default-off";
 		};
 
 		5ghz {
 			label = "bcm53xx:blue:5ghz";
 			gpios = <&chipcommon 11 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "default-off";
 		};
 
 		system {
@@ -54,7 +51,6 @@ 
 		2ghz {
 			label = "bcm53xx:blue:2ghz";
 			gpios = <&pcie0_chipcommon 3 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "default-off";
 		};
 	};