[v2,2/2] linux: Add CIP SLTS easy selection option

Message ID 1488925428-12805-3-git-send-email-angelo.compagnucci@gmail.com
State Superseded
Headers show

Commit Message

Angelo Compagnucci March 7, 2017, 10:23 p.m.
This patch adds an easy way to select the CIP project SLTS
kernel within the kernel menu.

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
 linux/Config.in | 25 +++++++++++++++++++++++++
 linux/linux.mk  |  4 ++++
 2 files changed, 29 insertions(+)

Comments

Thomas Petazzoni April 1, 2017, 4:48 p.m. | #1
Hello,

On Tue,  7 Mar 2017 23:23:48 +0100, Angelo Compagnucci wrote:
> This patch adds an easy way to select the CIP project SLTS
> kernel within the kernel menu.
> 
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>

> +	config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
> +		bool "Latest tagged version (v4.4.48-cip2)"
> +		help
> +		  Use the latest tagged version
> +
> +	config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH
> +		bool "Latest released version"
> +		help
> +		  Always use the latest released version at the time of compiling

I still won't take a patch that adds an option like this. It makes the
build non reproducible, which is plain and simply unacceptable in
Buildroot. So until you remove this, this patch cannot be accepted.

> +else ifeq ($(BR2_LINUX_KERNEL_LATEST_CIP_VERSION),y)
> +LINUX_SITE = $(call gitlab,cip-project,cip-kernel-4.4,$(LINUX_VERSION))
> +LINUX_SOURCE = linux-$(LINUX_VERSION).tar.bz2

According to
https://wiki.linuxfoundation.org/civilinfrastructureplatform/start,
gitlab is only a mirror, and the official Git repository is
https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git/.

And in fact, according to
https://lists.cip-project.org/pipermail/cip-dev/2017-March/000167.html,
they even say that the gitlab mirror is no longer updated that
regularly due to technical issues.

So could you rework your patch using git.kernel.org instead of gitlab
(and therefore dropping the gitlab helper), and also dropping the
BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH option ?

Thanks,

Thomas
Angelo Compagnucci April 6, 2017, 5 p.m. | #2
Dear Thomas Petazzoni,

2017-04-01 18:48 GMT+02:00 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com>:

> Hello,
>
> On Tue,  7 Mar 2017 23:23:48 +0100, Angelo Compagnucci wrote:
> > This patch adds an easy way to select the CIP project SLTS
> > kernel within the kernel menu.
> >
> > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>
> > +     config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
> > +             bool "Latest tagged version (v4.4.48-cip2)"
> > +             help
> > +               Use the latest tagged version
> > +
> > +     config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH
> > +             bool "Latest released version"
> > +             help
> > +               Always use the latest released version at the time of
> compiling
>
> I still won't take a patch that adds an option like this. It makes the
> build non reproducible, which is plain and simply unacceptable in
> Buildroot. So until you remove this, this patch cannot be accepted.
>
> > +else ifeq ($(BR2_LINUX_KERNEL_LATEST_CIP_VERSION),y)
> > +LINUX_SITE = $(call gitlab,cip-project,cip-kernel-4.4,$(LINUX_VERSION))
> > +LINUX_SOURCE = linux-$(LINUX_VERSION).tar.bz2
>
> According to
> https://wiki.linuxfoundation.org/civilinfrastructureplatform/start,
> gitlab is only a mirror, and the official Git repository is
> https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git/.
>
> And in fact, according to
> https://lists.cip-project.org/pipermail/cip-dev/2017-March/000167.html,
> they even say that the gitlab mirror is no longer updated that
> regularly due to technical issues.
>
> So could you rework your patch using git.kernel.org instead of gitlab
> (and therefore dropping the gitlab helper), and also dropping the
> BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH option ?
>

Done!

Hope this time it will be accepted!


>
> Thanks,
>

Thank you so much for the patience!


>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>

Patch

diff --git a/linux/Config.in b/linux/Config.in
index 1707f7d..76acece 100644
--- a/linux/Config.in
+++ b/linux/Config.in
@@ -28,6 +28,9 @@  choice
 config BR2_LINUX_KERNEL_LATEST_VERSION
 	bool "Latest version (4.10.1)"
 
+config BR2_LINUX_KERNEL_LATEST_CIP_VERSION
+	bool "Latest CIP SLTS (Super Long Term Support)"
+
 config BR2_LINUX_KERNEL_CUSTOM_VERSION
 	bool "Custom version"
 	help
@@ -95,9 +98,31 @@  config BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION
 
 endif
 
+if BR2_LINUX_KERNEL_LATEST_CIP_VERSION
+
+choice
+	prompt "CIP version"
+	default BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
+
+	config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
+		bool "Latest tagged version (v4.4.48-cip2)"
+		help
+		  Use the latest tagged version
+
+	config BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH
+		bool "Latest released version"
+		help
+		  Always use the latest released version at the time of compiling
+
+endchoice
+
+endif
+
 config BR2_LINUX_KERNEL_VERSION
 	string
 	default "4.10.1" if BR2_LINUX_KERNEL_LATEST_VERSION
+	default "v4.4.48-cip2" if BR2_LINUX_KERNEL_LATEST_CIP_VERSION_TAG
+	default "linux-4.4.y-cip" if BR2_LINUX_KERNEL_LATEST_CIP_VERSION_BRANCH
 	default BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE \
 		if BR2_LINUX_KERNEL_CUSTOM_VERSION
 	default "custom" if BR2_LINUX_KERNEL_CUSTOM_TARBALL
diff --git a/linux/linux.mk b/linux/linux.mk
index 7f4432e..473a198 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -30,6 +30,10 @@  LINUX_SITE_METHOD = hg
 else ifeq ($(BR2_LINUX_KERNEL_CUSTOM_SVN),y)
 LINUX_SITE = $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_REPO_URL))
 LINUX_SITE_METHOD = svn
+else ifeq ($(BR2_LINUX_KERNEL_LATEST_CIP_VERSION),y)
+LINUX_SITE = $(call gitlab,cip-project,cip-kernel-4.4,$(LINUX_VERSION))
+LINUX_SOURCE = linux-$(LINUX_VERSION).tar.bz2
+BR_NO_CHECK_HASH_FOR += $(LINUX_SOURCE)
 else
 LINUX_SOURCE = linux-$(LINUX_VERSION).tar.xz
 ifeq ($(BR2_LINUX_KERNEL_CUSTOM_VERSION),y)