| Message ID | 1488876018-31576-1-git-send-email-kraxel@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 7 Mar 2017, Gerd Hoffmann wrote: > The strict td link limit added by commit "95ed569 usb: ohci: limit the > number of link eds" causes problems with macos guests. Lets raise the > limit. > > Reported-by: Programmingkid <programmingkidx@gmail.com> > Reported-by: Howard Spoelstra <hsp.cat7@gmail.com> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> I've also tested that this fixes mouse under MorphOS as well. However I'm not sure that this limit is correct for every possible USB devices so this may need to be increased in the future if a device is found needing more linked TDs. > --- > hw/usb/hcd-ohci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index fe8406a..3ada35e 100644 > --- a/hw/usb/hcd-ohci.c > +++ b/hw/usb/hcd-ohci.c > @@ -42,7 +42,7 @@ > > #define OHCI_MAX_PORTS 15 > > -#define ED_LINK_LIMIT 4 > +#define ED_LINK_LIMIT 32 > > static int64_t usb_frame_time; > static int64_t usb_bit_time; >
On Mar 7, 2017, at 3:40 AM, Gerd Hoffmann wrote: > The strict td link limit added by commit "95ed569 usb: ohci: limit the > number of link eds" causes problems with macos guests. Lets raise the > limit. > > Reported-by: Programmingkid <programmingkidx@gmail.com> > Reported-by: Howard Spoelstra <hsp.cat7@gmail.com> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > hw/usb/hcd-ohci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index fe8406a..3ada35e 100644 > --- a/hw/usb/hcd-ohci.c > +++ b/hw/usb/hcd-ohci.c > @@ -42,7 +42,7 @@ > > #define OHCI_MAX_PORTS 15 > > -#define ED_LINK_LIMIT 4 > +#define ED_LINK_LIMIT 32 > > static int64_t usb_frame_time; > static int64_t usb_bit_time; > -- > 1.8.3.1 Reviewed-by: John Arbuckle <programmingkidx@gmail.com> Tested with Mac OS 10.4 and Mac OS 9.2.
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index fe8406a..3ada35e 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -42,7 +42,7 @@ #define OHCI_MAX_PORTS 15 -#define ED_LINK_LIMIT 4 +#define ED_LINK_LIMIT 32 static int64_t usb_frame_time; static int64_t usb_bit_time;
The strict td link limit added by commit "95ed569 usb: ohci: limit the number of link eds" causes problems with macos guests. Lets raise the limit. Reported-by: Programmingkid <programmingkidx@gmail.com> Reported-by: Howard Spoelstra <hsp.cat7@gmail.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- hw/usb/hcd-ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)