From patchwork Tue Nov 30 13:52:20 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alexander V. Lukyanov" X-Patchwork-Id: 73602 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F3C831007D1 for ; Wed, 1 Dec 2010 00:53:50 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751963Ab0K3Nxt (ORCPT ); Tue, 30 Nov 2010 08:53:49 -0500 Received: from fire-ce0.netis.ru ([193.233.48.99]:42212 "EHLO fire.netis.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651Ab0K3Nxt (ORCPT ); Tue, 30 Nov 2010 08:53:49 -0500 Received: from proxy.yar.ru (proxy.yar.ru [193.233.48.78]) by fire.netis.ru (8.14.3/8.14.2) with ESMTP id oAUDqMDq022395; Tue, 30 Nov 2010 16:52:24 +0300 (MSK) Received: (from root@localhost) by proxy.yar.ru (8.14.4/8.14.2/Submit) id oAUDqL2m022365; Tue, 30 Nov 2010 16:52:21 +0300 Date: Tue, 30 Nov 2010 16:52:20 +0300 From: "Alexander V. Lukyanov" To: linux-ext4@vger.kernel.org Cc: "Theodore Ts'o" , Andreas Dilger , linux-kernel@vger.kernel.org Subject: [PATCH] allow inode_readahead_blks=0 Message-ID: <20101130135219.GA22357@proxy> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-NETIS-MailScanner-Information: Please contact NETIS Telecom for more information (+7 4852 797797) X-NETIS-MailScanner-ID: oAUDqMDq022395 X-NETIS-MailScanner: Found to be clean X-NETIS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=0.001, required 6, autolearn=disabled, FSL_RU_URL 0.00) X-NETIS-MailScanner-From: root@proxy.yar.ru X-NETIS-MailScanner-To: adilger@sun.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, tytso@mit.edu X-Spam-Status: No Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hello! Currently the value 0 is disallowed, as it is not a power of 2. This obvious patch fixes the problem. Signed-off-by: Alexander V. Lukyanov --- fs/ext4/super.c.0 2010-11-16 10:48:33.418629215 +0300 +++ fs/ext4/super.c 2010-11-16 10:46:07.739753246 +0300 @@ -1657,7 +1657,7 @@ set_qf_format: return 0; if (option < 0 || option > (1 << 30)) return 0; - if (!is_power_of_2(option)) { + if (option && !is_power_of_2(option)) { ext4_msg(sb, KERN_ERR, "EXT4-fs: inode_readahead_blks" " must be a power of 2"); @@ -2274,7 +2274,7 @@ static ssize_t inode_readahead_blks_stor if (parse_strtoul(buf, 0x40000000, &t)) return -EINVAL; - if (!is_power_of_2(t)) + if (t && !is_power_of_2(t)) return -EINVAL; sbi->s_inode_readahead_blks = t;