diff mbox

net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

Message ID 1488672115-11057-1-git-send-email-khoroshilov@ispras.ru
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Alexey Khoroshilov March 5, 2017, 12:01 a.m. UTC 
Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 net/sched/act_skbmod.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jamal Hadi Salim March 5, 2017, 2:21 a.m. UTC | #1 
On 17-03-04 07:01 PM, Alexey Khoroshilov wrote:
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal
David Miller March 7, 2017, 10:13 p.m. UTC | #2 
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sun,  5 Mar 2017 03:01:55 +0300

> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Applied and queued up for -stable, thanks.
diff mbox

Patch

diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c
index 3b7074e23024..c736627f8f4a 100644
--- a/net/sched/act_skbmod.c
+++ b/net/sched/act_skbmod.c
@@ -228,7 +228,6 @@  static int tcf_skbmod_dump(struct sk_buff *skb, struct tc_action *a,
 
 	return skb->len;
 nla_put_failure:
-	rcu_read_unlock();
 	nlmsg_trim(skb, b);
 	return -1;
 }