| Message ID | 20170303131113.25898-5-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Mar 03, 2017 at 02:11:12PM +0100, Paolo Bonzini wrote: > This optimization is not necessary anymore, because the vCPU now drops > the I/O thread lock even with TCG. Drop it to simplify the code and > avoid the "I/O thread spun for 1000 iterations" warning. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > vl.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/vl.c b/vl.c > index bbbf1ba..b21b57e 100644 > --- a/vl.c > +++ b/vl.c > @@ -1884,17 +1884,14 @@ static bool main_loop_should_exit(void) > > static void main_loop(void) > { > - bool nonblocking; > - int last_io = 0; > #ifdef CONFIG_PROFILER > int64_t ti; > #endif > do { > - nonblocking = tcg_enabled() && last_io > 0; > #ifdef CONFIG_PROFILER > ti = profile_getclock(); > #endif > - last_io = main_loop_wait(nonblocking); > + main_loop_wait(false); > #ifdef CONFIG_PROFILER > dev_time += profile_getclock() - ti; > #endif > -- > 2.9.3 > > >
Paolo Bonzini <pbonzini@redhat.com> writes: > This optimization is not necessary anymore, because the vCPU now drops > the I/O thread lock even with TCG. Drop it to simplify the code and > avoid the "I/O thread spun for 1000 iterations" warning. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > vl.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/vl.c b/vl.c > index bbbf1ba..b21b57e 100644 > --- a/vl.c > +++ b/vl.c > @@ -1884,17 +1884,14 @@ static bool main_loop_should_exit(void) > > static void main_loop(void) > { > - bool nonblocking; > - int last_io = 0; > #ifdef CONFIG_PROFILER > int64_t ti; > #endif > do { > - nonblocking = tcg_enabled() && last_io > 0; > #ifdef CONFIG_PROFILER > ti = profile_getclock(); > #endif > - last_io = main_loop_wait(nonblocking); > + main_loop_wait(false); > #ifdef CONFIG_PROFILER > dev_time += profile_getclock() - ti; > #endif -- Alex Bennée
diff --git a/vl.c b/vl.c index bbbf1ba..b21b57e 100644 --- a/vl.c +++ b/vl.c @@ -1884,17 +1884,14 @@ static bool main_loop_should_exit(void) static void main_loop(void) { - bool nonblocking; - int last_io = 0; #ifdef CONFIG_PROFILER int64_t ti; #endif do { - nonblocking = tcg_enabled() && last_io > 0; #ifdef CONFIG_PROFILER ti = profile_getclock(); #endif - last_io = main_loop_wait(nonblocking); + main_loop_wait(false); #ifdef CONFIG_PROFILER dev_time += profile_getclock() - ti; #endif
This optimization is not necessary anymore, because the vCPU now drops the I/O thread lock even with TCG. Drop it to simplify the code and avoid the "I/O thread spun for 1000 iterations" warning. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- vl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)