Patchwork mlx4_en: Start port error flow bug fix

login
register
mail settings
Submitter Yevgeny Petrilin
Date Nov. 5, 2008, 2:53 p.m.
Message ID <4911B37E.3020900@mellanox.co.il>
Download mbox | patch
Permalink /patch/7350/
State Accepted
Delegated to: Jeff Garzik
Headers show

Comments

Yevgeny Petrilin - Nov. 5, 2008, 2:53 p.m.
Tried to deactivate rx ring that wasn't activated,
used wrong index.

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
---
 drivers/net/mlx4/en_netdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Jeff Garzik - Nov. 6, 2008, 5:43 a.m.
Yevgeny Petrilin wrote:
> Tried to deactivate rx ring that wasn't activated,
> used wrong index.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
> ---
>  drivers/net/mlx4/en_netdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/mlx4/en_netdev.c b/drivers/net/mlx4/en_netdev.c
> index 12d736a..96e709d 100644
> --- a/drivers/net/mlx4/en_netdev.c
> +++ b/drivers/net/mlx4/en_netdev.c
> @@ -706,7 +706,7 @@ tx_err:
>  	mlx4_en_release_rss_steer(priv);
>  rx_err:
>  	for (i = 0; i < priv->rx_ring_num; i++)
> -		mlx4_en_deactivate_rx_ring(priv, &priv->rx_ring[rx_index]);
> +		mlx4_en_deactivate_rx_ring(priv, &priv->rx_ring[i]);
>  cq_err:

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/mlx4/en_netdev.c b/drivers/net/mlx4/en_netdev.c
index 12d736a..96e709d 100644
--- a/drivers/net/mlx4/en_netdev.c
+++ b/drivers/net/mlx4/en_netdev.c
@@ -706,7 +706,7 @@  tx_err:
 	mlx4_en_release_rss_steer(priv);
 rx_err:
 	for (i = 0; i < priv->rx_ring_num; i++)
-		mlx4_en_deactivate_rx_ring(priv, &priv->rx_ring[rx_index]);
+		mlx4_en_deactivate_rx_ring(priv, &priv->rx_ring[i]);
 cq_err:
 	while (rx_index--)
 		mlx4_en_deactivate_cq(priv, &priv->rx_cq[rx_index]);