| Message ID | 1488486276-24552-1-git-send-email-xiyou.wangcong@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Cong Wang <xiyou.wangcong@gmail.com> wrote: >This restores the ability of setting bond device's mtu to 9000. > >Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") >Reported-by: daznis@gmail.com >Reported-by: Brad Campbell <lists2009@fnarfbargle.com> >Cc: Jarod Wilson <jarod@redhat.com> >Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> >--- > drivers/net/bonding/bond_main.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index 6321f12..8a4ba8b 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -4179,6 +4179,7 @@ void bond_setup(struct net_device *bond_dev) > > /* Initialize the device entry points */ > ether_setup(bond_dev); >+ bond_dev->max_mtu = ETH_MAX_MTU; > bond_dev->netdev_ops = &bond_netdev_ops; > bond_dev->ethtool_ops = &bond_ethtool_ops; Signed-off-by: Jay Vosburgh <jay.vosburgh@canonical.com> -J --- -Jay Vosburgh, jay.vosburgh@canonical.com
From: Cong Wang <xiyou.wangcong@gmail.com> Date: Thu, 2 Mar 2017 12:24:36 -0800 > This restores the ability of setting bond device's mtu to 9000. > > Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") > Reported-by: daznis@gmail.com > Reported-by: Brad Campbell <lists2009@fnarfbargle.com> > Cc: Jarod Wilson <jarod@redhat.com> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Applied and queued up for -stable, thanks.
On 03/03/17 06:43, David Miller wrote: > From: Cong Wang <xiyou.wangcong@gmail.com> > Date: Thu, 2 Mar 2017 12:24:36 -0800 > >> This restores the ability of setting bond device's mtu to 9000. >> >> Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") >> Reported-by: daznis@gmail.com >> Reported-by: Brad Campbell <lists2009@fnarfbargle.com> >> Cc: Jarod Wilson <jarod@redhat.com> >> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > > Applied and queued up for -stable, thanks. > Thanks very much for this. I've tested it against 4.10.1 and it does the job nicely. Regards, Brad
On 2017-03-02 3:24 PM, Cong Wang wrote: > This restores the ability of setting bond device's mtu to 9000. > > Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") > Reported-by: daznis@gmail.com > Reported-by: Brad Campbell <lists2009@fnarfbargle.com> > Cc: Jarod Wilson <jarod@redhat.com> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Apologies, I'm a bit late to the party, direct CC didn't land in inbox because of duplicate suppression or perhaps a greedy mail filtering rule (*grumble*)... Too late to ack, but yeah, that's necessary. I *think* the team driver may also require the same treatment. It calls ether_setup() without anything setting max_mtu as well.
Mon, Mar 06, 2017 at 02:36:47PM CET, jarod@redhat.com wrote: >On 2017-03-02 3:24 PM, Cong Wang wrote: >> This restores the ability of setting bond device's mtu to 9000. >> >> Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") >> Reported-by: daznis@gmail.com >> Reported-by: Brad Campbell <lists2009@fnarfbargle.com> >> Cc: Jarod Wilson <jarod@redhat.com> >> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > >Apologies, I'm a bit late to the party, direct CC didn't land in inbox >because of duplicate suppression or perhaps a greedy mail filtering rule >(*grumble*)... Too late to ack, but yeah, that's necessary. I *think* the >team driver may also require the same treatment. It calls ether_setup() >without anything setting max_mtu as well. Jarod, could you please send the fix? Thanks.
On 2017-03-06 8:40 AM, Jiri Pirko wrote: > Mon, Mar 06, 2017 at 02:36:47PM CET, jarod@redhat.com wrote: >> On 2017-03-02 3:24 PM, Cong Wang wrote: >>> This restores the ability of setting bond device's mtu to 9000. >>> >>> Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") >>> Reported-by: daznis@gmail.com >>> Reported-by: Brad Campbell <lists2009@fnarfbargle.com> >>> Cc: Jarod Wilson <jarod@redhat.com> >>> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> >> >> Apologies, I'm a bit late to the party, direct CC didn't land in inbox >> because of duplicate suppression or perhaps a greedy mail filtering rule >> (*grumble*)... Too late to ack, but yeah, that's necessary. I *think* the >> team driver may also require the same treatment. It calls ether_setup() >> without anything setting max_mtu as well. > > Jarod, could you please send the fix? Thanks. Done.
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 6321f12..8a4ba8b 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -4179,6 +4179,7 @@ void bond_setup(struct net_device *bond_dev) /* Initialize the device entry points */ ether_setup(bond_dev); + bond_dev->max_mtu = ETH_MAX_MTU; bond_dev->netdev_ops = &bond_netdev_ops; bond_dev->ethtool_ops = &bond_ethtool_ops;
This restores the ability of setting bond device's mtu to 9000. Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") Reported-by: daznis@gmail.com Reported-by: Brad Campbell <lists2009@fnarfbargle.com> Cc: Jarod Wilson <jarod@redhat.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> --- drivers/net/bonding/bond_main.c | 1 + 1 file changed, 1 insertion(+)