| Message ID | CAFULd4a_DTVQWLxETsaBxyAi7wPPpKPUee=C2tt79_8+D-Ty_Q@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Thu, 2 Mar 2017, Uros Bizjak wrote: > > Annoying me for quite some time, fixed as follows. > > > > Tested on x86_64-unknown-linux-gnu, applied to trunk. > > Index: gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c > =================================================================== > --- gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c (revision 245830) > +++ gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c (working copy) > @@ -1,4 +1,4 @@ > -/* { dg-do run { target x86_64-*-* } } */ > +/* { dg-do run { target { x86_64-*-* && lp64 } } } */ > > All hese should be "{ target { { i?86-*-* x86_64-*-* } && { ! ia32 } } > }". x32 works OK with all test, modulo final.c where it ICEs for some > reason. AFAIK they were testcases with RTL generated for x86_64 lp64 so restricting to that is appropriate IMHO (do we really support -m64 on i?86-*-*?) But feel free to adjust them as you see fit - I was just annoyed by the persisting FAILs. Thanks, Richard.
On Thu, Mar 2, 2017 at 10:10 AM, Richard Biener <rguenther@suse.de> wrote: > On Thu, 2 Mar 2017, Uros Bizjak wrote: > >> > Annoying me for quite some time, fixed as follows. >> > >> > Tested on x86_64-unknown-linux-gnu, applied to trunk. >> >> Index: gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c >> =================================================================== >> --- gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c (revision 245830) >> +++ gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c (working copy) >> @@ -1,4 +1,4 @@ >> -/* { dg-do run { target x86_64-*-* } } */ >> +/* { dg-do run { target { x86_64-*-* && lp64 } } } */ >> >> All hese should be "{ target { { i?86-*-* x86_64-*-* } && { ! ia32 } } >> }". x32 works OK with all test, modulo final.c where it ICEs for some >> reason. > > AFAIK they were testcases with RTL generated for x86_64 lp64 so > restricting to that is appropriate IMHO (do we really support > -m64 on i?86-*-*?) Yes, e.g. i386-pc-solaris2.11 [1]. > But feel free to adjust them as you see fit - I was just annoyed > by the persisting FAILs. OK, no problem for me. [1] https://gcc.gnu.org/ml/gcc-testresults/2017-02/msg02895.html Uros.
Index: gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c =================================================================== --- gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c (revision 245830) +++ gcc/testsuite/gcc.dg/rtl/x86_64/dfinit.c (working copy) @@ -1,4 +1,4 @@ -/* { dg-do run { target x86_64-*-* } } */ +/* { dg-do run { target { x86_64-*-* && lp64 } } } */ All hese should be "{ target { { i?86-*-* x86_64-*-* } && { ! ia32 } } }". x32 works OK with all test, modulo final.c where it ICEs for some