Patchwork [U-Boot] "usb reset" issue with some pen drives which work well in Linux/Windows

login
register
mail settings
Submitter Debashish Rath
Date Nov. 29, 2010, 12:18 p.m.
Message ID <24A35C16137FE049838D189639DD567F0846F945@eu-exh-02.EU.TRID.COM>
Download mbox | patch
Permalink /patch/73418/
State Changes Requested
Headers show

Comments

Debashish Rath - Nov. 29, 2010, 12:18 p.m.
Dear Mr. Wolfgang,
Please find the patch for the same. This is ok or I have to prepare  a different mail and send the patch as an attachment.
Regards
Debashish Rath


--------------------------PATCH START--------------



------------------------PATCH END-----------------------------



-----Original Message-----
From: Wolfgang Denk [mailto:wd@denx.de]
Sent: Monday, November 29, 2010 5:02 PM
To: Debashish Rath
Cc: u-boot@lists.denx.de
Subject: Re: [U-Boot] "usb reset" issue with some pen drives which work well in Linux/Windows

Dear Debashish Rath,

In message <24A35C16137FE049838D189639DD567F0846F87C@eu-exh-02.EU.TRID.COM> you wrote:
>
> I found the issue.
> In usb_stor_get_info function of common/usb_storage.c I add the following:
>             (dev->descriptor.idVendor =3D=3D 0x0204 &&
>              dev->descriptor.idProduct =3D=3D 0x6025)
>
> to skip the ss->transport_reset(ss);. This I took out from the linux kernel=
>  code.
>
> Now its working for me.

Congratulations.  Can you now please submit this change as a proper
patch so others can benefit from it, too?

Please see here for help: http://www.denx.de/wiki/U-Boot/Patches

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Microsoft Multitasking:
                     several applications can crash at the same time.
Remy Bohmer - Dec. 9, 2010, 6:46 p.m.
Hi,

2010/11/29 Debashish Rath <Debashish.Rath@tridentmicro.com>:
> Dear Mr. Wolfgang,
> Please find the patch for the same. This is ok or I have to prepare  a different mail and send the patch as an attachment.

No, please not post it as attachment.

> Regards
> Debashish Rath
>
>
> --------------------------PATCH START--------------

Missing proper patch description.
Missing Signed-off-by.

Please fix.

As Wolfgang already suggested, please see
http://www.denx.de/wiki/U-Boot/Patches for how to post patches.

Kind regards,

Remy

Patch

diff -Naur u-boot-2010.09/common/usb_storage.c u-boot-2010.09_usb_ms_reset/common/usb_storage.c
--- u-boot-2010.09/common/usb_storage.c 2010-09-29 02:50:55.000000000 +0530
+++ u-boot-2010.09_usb_ms_reset/common/usb_storage.c    2010-11-29 17:16:01.825110000 +0530
@@ -1335,6 +1335,13 @@ 
             */
            (dev->descriptor.idVendor == 0x0781 &&
             dev->descriptor.idProduct == 0x5406)
+            ||
+            /*
+             * Standard Disk Drives
+             * USB Flash Memory
+             */
+            (dev->descriptor.idVendor == 0x0204 &&
+             dev->descriptor.idProduct == 0x6025)
            )
                USB_STOR_PRINTF("usb_stor_get_info: skipping RESET..\n");
        else