diff mbox

Suppress compiler warning in libgcc/unwind-seh.c

Message ID fa292efc-6388-2825-07da-c950dd65e524@gmail.com
State New
Headers show

Commit Message

Jonathan Yong March 1, 2017, 11:36 a.m. UTC 
Patch OK?

ChangeLog:
	* unwind-seh.c: Suppress warnings for RtlUnwindEx() calls.

Comments

Jonathan Yong March 2, 2017, 11:05 a.m. UTC | #1 
On 03/01/2017 11:36 AM, JonY wrote:
> Patch OK?
> 
> ChangeLog:
> 	* unwind-seh.c: Suppress warnings for RtlUnwindEx() calls.
> 

Applied, tested with x86_64-w64-mingw32 to trunk.
Jeff Law March 15, 2017, 4:12 a.m. UTC | #2 
On 03/01/2017 04:36 AM, JonY wrote:
> Patch OK?
>
> ChangeLog:
> 	* unwind-seh.c: Suppress warnings for RtlUnwindEx() calls.
You know this stuff better than anyone else working with GCC.  If you 
think this is the right thing to do for the SEH code, go for it.

jeff
Jonathan Yong March 15, 2017, 10:53 a.m. UTC | #3 
On 03/15/2017 04:12 AM, Jeff Law wrote:
> On 03/01/2017 04:36 AM, JonY wrote:
>> Patch OK?
>>
>> ChangeLog:
>>     * unwind-seh.c: Suppress warnings for RtlUnwindEx() calls.
> You know this stuff better than anyone else working with GCC.  If you
> think this is the right thing to do for the SEH code, go for it.
> 
> jeff
> 
> 

Already applied to trunk, thanks.
diff mbox

Patch

Index: libgcc/unwind-seh.c
===================================================================
--- libgcc/unwind-seh.c	(revision 245806)
+++ libgcc/unwind-seh.c	(working copy)
@@ -221,7 +221,7 @@ 
 	 test is that we're the target frame.  */
       if (ms_exc->ExceptionInformation[1] == (_Unwind_Ptr) this_frame)
 	{
-	  RtlUnwindEx (this_frame, ms_exc->ExceptionInformation[2],
+	  RtlUnwindEx (this_frame, (PVOID) ms_exc->ExceptionInformation[2],
 		       ms_exc, gcc_exc, ms_orig_context,
 		       ms_disp->HistoryTable);
 	  abort ();
@@ -313,7 +313,7 @@ 
 	  ms_exc->ExceptionInformation[3] = gcc_context.reg[1];
 
 	  /* Begin phase 2.  Perform the unwinding.  */
-	  RtlUnwindEx (this_frame, gcc_context.ra, ms_exc,
+	  RtlUnwindEx (this_frame, (PVOID)gcc_context.ra, ms_exc,
 		       (PVOID)gcc_context.reg[0], ms_orig_context,
 		       ms_disp->HistoryTable);
 	}
@@ -365,7 +365,7 @@ 
   ms_context.ContextFlags = CONTEXT_ALL;
   RtlCaptureContext (&ms_context);
 
-  RtlUnwindEx ((void *) gcc_exc->private_[1], gcc_exc->private_[2],
+  RtlUnwindEx ((void *) gcc_exc->private_[1], (PVOID)gcc_exc->private_[2],
 	       &ms_exc, gcc_exc, &ms_context, &ms_history);
 
   /* Is RtlUnwindEx declared noreturn?  */