diff mbox

[1/8] nanddump/nandwrite: use "simple_" str functions

Message ID 1291017722-23985-1-git-send-email-computersforpeace@gmail.com
State Accepted
Commit 340ccfc90f78e3fb762ce3da1ed5fbcd2e02a2bf
Headers show

Commit Message

Brian Norris Nov. 29, 2010, 8:01 a.m. UTC 
Per Mike Frysinger's suggestion, we check for strtoll() and strtoull()
errors by using the "common.h" helper functions simple_strtoll() and
simple_strtoull().

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 nanddump.c  |    4 ++--
 nandwrite.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Artem Bityutskiy Dec. 2, 2010, 3:27 a.m. UTC | #1 
On Mon, 2010-11-29 at 00:01 -0800, Brian Norris wrote:
> Per Mike Frysinger's suggestion, we check for strtoll() and strtoull()
> errors by using the "common.h" helper functions simple_strtoll() and
> simple_strtoull().
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>

Pushed the series, picked newest patches, thanks a lot!
diff mbox

Patch

diff --git a/nanddump.c b/nanddump.c
index fe29596..bf95e81 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -136,7 +136,7 @@  static void process_options(int argc, char * const argv[])
 				omitbad = true;
 				break;
 			case 's':
-				start_addr = strtoull(optarg, NULL, 0);
+				start_addr = simple_strtoull(optarg, &error);
 				break;
 			case 'f':
 				if (!(dumpfile = strdup(optarg))) {
@@ -145,7 +145,7 @@  static void process_options(int argc, char * const argv[])
 				}
 				break;
 			case 'l':
-				length = strtoull(optarg, NULL, 0);
+				length = simple_strtoull(optarg, &error);
 				break;
 			case 'o':
 				omitoob = true;
diff --git a/nandwrite.c b/nandwrite.c
index bbe69b0..5373a89 100644
--- a/nandwrite.c
+++ b/nandwrite.c
@@ -201,7 +201,7 @@  static void process_options(int argc, char * const argv[])
 				writeoob = true;
 				break;
 			case 's':
-				mtdoffset = strtoll(optarg, NULL, 0);
+				mtdoffset = simple_strtoll(optarg, &error);
 				break;
 			case 'b':
 				blockalign = atoi(optarg);