| Message ID | 20170228063535.32069-4-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
On Tue, Feb 28, 2017 at 07:35:13AM +0100, Andreas Färber wrote: > The Actions Semi S500 SoC contains a timer block with two 2 Hz and two > 32-bit timers. The S900 SoC timer block has four 32-bit timers. > > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > v2 -> v3: > * Adopted interrupt-names > * Changed compatible for S500 > * Added S900 compatible and interrupt names > > v2: new > > .../devicetree/bindings/timer/actions,owl-timer.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > new file mode 100644 > index 0000000..5b4834d > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > @@ -0,0 +1,20 @@ > +Actions Semi Owl Timer > + > +Required properties: > +- compatible : "actions,s500-timer" for S500 > + "actions,s900-timer" for S900 > +- reg : Offset and length of the register set for the device. > +- interrupts : Should contain the interrupts. > +- interrupt-names : Valid names are: "2Hz0", "2Hz1", > + "Timer0", "Timer1", "Timer2", "Timer3" Sticking to lower case for the names would be preferable. Otherwise, this looks fine. Mark,.
On Tue, Feb 28, 2017 at 12:39:08PM +0000, Mark Rutland wrote: > On Tue, Feb 28, 2017 at 07:35:13AM +0100, Andreas Färber wrote: > > The Actions Semi S500 SoC contains a timer block with two 2 Hz and two > > 32-bit timers. The S900 SoC timer block has four 32-bit timers. > > > > Signed-off-by: Andreas Färber <afaerber@suse.de> > > --- > > v2 -> v3: > > * Adopted interrupt-names > > * Changed compatible for S500 > > * Added S900 compatible and interrupt names > > > > v2: new > > > > .../devicetree/bindings/timer/actions,owl-timer.txt | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > > > diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > new file mode 100644 > > index 0000000..5b4834d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > @@ -0,0 +1,20 @@ > > +Actions Semi Owl Timer > > + > > +Required properties: > > +- compatible : "actions,s500-timer" for S500 > > + "actions,s900-timer" for S900 > > +- reg : Offset and length of the register set for the device. > > +- interrupts : Should contain the interrupts. > > +- interrupt-names : Valid names are: "2Hz0", "2Hz1", > > + "Timer0", "Timer1", "Timer2", "Timer3" > > Sticking to lower case for the names would be preferable. With that, Acked-by: Rob Herring <robh@kernel.org>
Am 03.03.2017 um 07:20 schrieb Rob Herring: > On Tue, Feb 28, 2017 at 12:39:08PM +0000, Mark Rutland wrote: >> On Tue, Feb 28, 2017 at 07:35:13AM +0100, Andreas Färber wrote: >>> The Actions Semi S500 SoC contains a timer block with two 2 Hz and two >>> 32-bit timers. The S900 SoC timer block has four 32-bit timers. >>> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> v2 -> v3: >>> * Adopted interrupt-names >>> * Changed compatible for S500 >>> * Added S900 compatible and interrupt names >>> >>> v2: new >>> >>> .../devicetree/bindings/timer/actions,owl-timer.txt | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/timer/actions,owl-timer.txt >>> >>> diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt >>> new file mode 100644 >>> index 0000000..5b4834d >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt >>> @@ -0,0 +1,20 @@ >>> +Actions Semi Owl Timer >>> + >>> +Required properties: >>> +- compatible : "actions,s500-timer" for S500 >>> + "actions,s900-timer" for S900 >>> +- reg : Offset and length of the register set for the device. >>> +- interrupts : Should contain the interrupts. >>> +- interrupt-names : Valid names are: "2Hz0", "2Hz1", >>> + "Timer0", "Timer1", "Timer2", "Timer3" >> >> Sticking to lower case for the names would be preferable. Done. > With that, > > Acked-by: Rob Herring <robh@kernel.org> Thanks, Andreas
diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt new file mode 100644 index 0000000..5b4834d --- /dev/null +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt @@ -0,0 +1,20 @@ +Actions Semi Owl Timer + +Required properties: +- compatible : "actions,s500-timer" for S500 + "actions,s900-timer" for S900 +- reg : Offset and length of the register set for the device. +- interrupts : Should contain the interrupts. +- interrupt-names : Valid names are: "2Hz0", "2Hz1", + "Timer0", "Timer1", "Timer2", "Timer3" + See ../resource-names.txt + +Example: + + timer@b0168000 { + compatible = "actions,s500-timer"; + reg = <0xb0168000 0x100>; + interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "Timer0", "Timer1"; + };
The Actions Semi S500 SoC contains a timer block with two 2 Hz and two 32-bit timers. The S900 SoC timer block has four 32-bit timers. Signed-off-by: Andreas Färber <afaerber@suse.de> --- v2 -> v3: * Adopted interrupt-names * Changed compatible for S500 * Added S900 compatible and interrupt names v2: new .../devicetree/bindings/timer/actions,owl-timer.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/actions,owl-timer.txt