Message ID | 20170227115204.00f92846@gandalf.local.home (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
On Mon, 27 Feb 2017 11:52:04 -0500 "Steven Rostedt (VMware)" <rostedt@goodmis.org> wrote: > Let's not remove the warning about offsets and return probes when the > offset is invalid. Agreed, This looks good to me. Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Thanks! > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > --- > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index 3f4f788..f626235 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -695,6 +695,11 @@ static int create_trace_kprobe(int argc, char **argv) > pr_info("Failed to parse symbol.\n"); > return ret; > } > + if (offset && is_return && > + !arch_function_offset_within_entry(offset)) { > + pr_info("Given offset is not valid for return probe.\n"); > + return -EINVAL; > + } > } > argc -= 2; argv += 2; >
On 2017/02/27 11:52AM, Steven Rostedt (VMware) wrote: > Let's not remove the warning about offsets and return probes when the > offset is invalid. Good point! Thanks, Steve! > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> > --- > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index 3f4f788..f626235 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -695,6 +695,11 @@ static int create_trace_kprobe(int argc, char **argv) > pr_info("Failed to parse symbol.\n"); > return ret; > } > + if (offset && is_return && > + !arch_function_offset_within_entry(offset)) { > + pr_info("Given offset is not valid for return probe.\n"); > + return -EINVAL; > + } > } > argc -= 2; argv += 2; > >
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 3f4f788..f626235 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -695,6 +695,11 @@ static int create_trace_kprobe(int argc, char **argv) pr_info("Failed to parse symbol.\n"); return ret; } + if (offset && is_return && + !arch_function_offset_within_entry(offset)) { + pr_info("Given offset is not valid for return probe.\n"); + return -EINVAL; + } } argc -= 2; argv += 2;
Let's not remove the warning about offsets and return probes when the offset is invalid. Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> ---