From patchwork Wed Nov 5 12:34:46 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark McLoughlin X-Patchwork-Id: 7328 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 3F740DDDFA for ; Wed, 5 Nov 2008 23:35:55 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754668AbYKEMfv (ORCPT ); Wed, 5 Nov 2008 07:35:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752004AbYKEMfu (ORCPT ); Wed, 5 Nov 2008 07:35:50 -0500 Received: from mail08.svc.cra.dublin.eircom.net ([159.134.118.24]:34530 "HELO mail08.svc.cra.dublin.eircom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754613AbYKEMft (ORCPT ); Wed, 5 Nov 2008 07:35:49 -0500 Received: (qmail 78931 messnum 13155347 invoked from network[83.71.38.82/83-71-38-82.b-ras1.srl.dublin.eircom.net]); 5 Nov 2008 12:35:45 -0000 Received: from 83-71-38-82.b-ras1.srl.dublin.eircom.net (HELO blaa.localdomain) (83.71.38.82) by mail08.svc.cra.dublin.eircom.net (qp 78931) with SMTP; 5 Nov 2008 12:35:45 -0000 Received: by blaa.localdomain (Postfix, from userid 500) id 0A4641BC011; Wed, 5 Nov 2008 12:34:46 +0000 (GMT) From: Mark McLoughlin To: Rusty Russell Cc: netdev@vger.kernel.org, Mark McLoughlin Subject: [PATCH] virtio_net: don't set NETIF_F_FRAGLIST Date: Wed, 5 Nov 2008 12:34:46 +0000 Message-Id: <1225888486-977-1-git-send-email-markmc@redhat.com> X-Mailer: git-send-email 1.5.4.3 In-Reply-To: <> References: <> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We don't handle skb_shared_info->frag_list, so we shouldn't be setting the NETIF_F_FRAGLIST flag. Signed-off-by: Mark McLoughlin --- drivers/net/virtio_net.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 0196a0d..9d4fdad 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -505,7 +505,7 @@ static int virtnet_probe(struct virtio_device *vdev) /* Do we support "hardware" checksums? */ if (csum && virtio_has_feature(vdev, VIRTIO_NET_F_CSUM)) { /* This opens up the world of extra features. */ - dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST; + dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG; if (gso && virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) { dev->features |= NETIF_F_TSO | NETIF_F_UFO | NETIF_F_TSO_ECN | NETIF_F_TSO6;