Patchwork [U-Boot,V2] bugfix: image header pointer change.

login
register
mail settings
Submitter Baidu Boy
Date Nov. 27, 2010, 11:44 a.m.
Message ID <AANLkTikQzT6XVdndnfwUMQU1TLovguzrYfzx6FB-ST7O@mail.gmail.com>
Download mbox | patch
Permalink /patch/73275/
State Changes Requested
Headers show

Comments

Baidu Boy - Nov. 27, 2010, 11:44 a.m.
Signed-off-by: Baidu Boy <liucai.lfn@gmail.com>
changes for V2:
  - avoid unrelated syntax changes
---
 common/cmd_bootm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

 		show_boot_progress (6);
Wolfgang Denk - Nov. 27, 2010, 12:12 p.m.
Dear Baidu Boy,

In message <AANLkTikQzT6XVdndnfwUMQU1TLovguzrYfzx6FB-ST7O@mail.gmail.com> you wrote:
> Signed-off-by: Baidu Boy <liucai.lfn@gmail.com>
> changes for V2:
>   - avoid unrelated syntax changes
> ---
>  common/cmd_bootm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Comments like the "changes for V2" gor _below_ the "---" ine, not
above.

And you still don't mention anything abut the problem you are fixing
in the commit message.

Best regards,

Wolfgang Denk
Baidu Boy - Nov. 27, 2010, 12:19 p.m.
Hi,Walfgang:

2010/11/27 Wolfgang Denk <wd@denx.de>:
> Dear Baidu Boy,
>
> Comments like the "changes for V2" gor _below_ the "---" ine, not
> above.
>
> And you still don't mention anything abut the problem you are fixing
> in the commit message.
>

we should use the new image header after we copied it from the uImage to the
&images->legacy_hdr_os_copy. So we should make
images->legacy_hdr_os  point to images->legacy_hdr_os_copy, not the original
image_header_t	*hdr
Wolfgang Denk - Nov. 27, 2010, 6:46 p.m.
Dear Baidu Boy,

In message <AANLkTikZPzRFhkTsLhZPdVMCmZ9a8fN8xmiABxgYvBmK@mail.gmail.com> you wrote:
> Hi,Walfgang:
> 
> 2010/11/27 Wolfgang Denk <wd@denx.de>:
> > Dear Baidu Boy,
> >
> > Comments like the "changes for V2" gor _below_ the "---" ine, not
> > above.
> >
> > And you still don't mention anything abut the problem you are fixing
> > in the commit message.
> >
> 
> we should use the new image header after we copied it from the uImage to the
> &images->legacy_hdr_os_copy. So we should make
> images->legacy_hdr_os  point to images->legacy_hdr_os_copy, not the original
> image_header_t	*hdr

Don't explain it in some mail on some mailing list - add such comments
to the commit message, please.


Best regards,

Wolfgang Denk

Patch

diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 1a024f1..8f9e5f1 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -896,7 +896,7 @@  static void *boot_get_kernel (cmd_tbl_t *cmdtp,
int flag, int argc, char * const
 		memmove (&images->legacy_hdr_os_copy, hdr, sizeof(image_header_t));

 		/* save pointer to image header */
-		images->legacy_hdr_os = hdr;
+		images->legacy_hdr_os = &images->legacy_hdr_os_copy;

 		images->legacy_hdr_valid = 1;