diff mbox

[2/2] dt-bindings: display: imx: entry for LAUSCR

Message ID 1488193030-13064-2-git-send-email-martin@kaiser.cx
State Changes Requested, archived
Headers show

Commit Message

Martin Kaiser Feb. 27, 2017, 10:56 a.m. UTC
Allow setting the LCDC AUS Mode Control Register from the device tree.
This setting is optional, the register is available only on imx21 and
compatible chipsets.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
 Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring March 2, 2017, 4:13 p.m. UTC | #1
On Mon, Feb 27, 2017 at 11:56:42AM +0100, Martin Kaiser wrote:
> Allow setting the LCDC AUS Mode Control Register from the device tree.
> This setting is optional, the register is available only on imx21 and
> compatible chipsets.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> index 7a5c0e2..bd5077f 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> @@ -13,6 +13,8 @@ Required nodes:
>  	Additional, the display node has to define properties:
>  	- bits-per-pixel: Bits per pixel
>  	- fsl,pcr: LCDC PCR value
> +	A display node may optionally define
> +	- fsl,lauscr: LCDC AUS Mode Control Register value (only for imx21)

Looks like we already got one, but generally we don't just put magic 
register values in the DT. What does this register control?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Martin Kaiser March 4, 2017, 8:52 a.m. UTC | #2
Hi,

Thus wrote Rob Herring (robh@kernel.org):

> On Mon, Feb 27, 2017 at 11:56:42AM +0100, Martin Kaiser wrote:

> >  	- fsl,pcr: LCDC PCR value
> > +	A display node may optionally define
> > +	- fsl,lauscr: LCDC AUS Mode Control Register value (only for imx21)

> Looks like we already got one, but generally we don't just put magic 
> register values in the DT. What does this register control?

it contains settings related to AUS mode. This mode sets different
mappings between framebuffer memory and display pixels. It seems that
these mappings were originally defined for displays from AUO.

The only bit from this register that I really need is "AUS mode on/off".
I could put this into the device tree instead of the entire register.

Best regards,
Martin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
index 7a5c0e2..bd5077f 100644
--- a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
+++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
@@ -13,6 +13,8 @@  Required nodes:
 	Additional, the display node has to define properties:
 	- bits-per-pixel: Bits per pixel
 	- fsl,pcr: LCDC PCR value
+	A display node may optionally define
+	- fsl,lauscr: LCDC AUS Mode Control Register value (only for imx21)
 
 Optional properties:
 - lcd-supply: Regulator for LCD supply voltage.