diff mbox

iproute2: tc: introduce build dependency on libnetlink

Message ID alpine.LSU.2.20.1702241826540.24579@cbobk.fhfr.pm
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Jiri Kosina Feb. 24, 2017, 5:28 p.m. UTC 
From: Jiri Kosina <jkosina@suse.cz>

Rebuilding libnetlink doesn't trigger rebuild of tc, which is wrong 
(especially so for builds where libnetlink.a gets statically linked into 
tc). Fix that by introducing an explicit dependency.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 tc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger Feb. 24, 2017, 11:13 p.m. UTC | #1 
On Fri, 24 Feb 2017 18:28:54 +0100 (CET)
Jiri Kosina <jikos@kernel.org> wrote:

> From: Jiri Kosina <jkosina@suse.cz>
> 
> Rebuilding libnetlink doesn't trigger rebuild of tc, which is wrong 
> (especially so for builds where libnetlink.a gets statically linked into 
> tc). Fix that by introducing an explicit dependency.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Makes sense, Applied
diff mbox

Patch

diff --git a/tc/Makefile b/tc/Makefile
index 6dd984f0..3f7fc939 100644
--- a/tc/Makefile
+++ b/tc/Makefile
@@ -127,7 +127,7 @@  MODDESTDIR := $(DESTDIR)$(LIBDIR)/tc
 
 all: tc $(TCSO)
 
-tc: $(TCOBJ) libtc.a
+tc: $(TCOBJ) $(LIBNETLINK) libtc.a
 	$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
 
 libtc.a: $(TCLIB)