diff mbox

[MIPS] Document -mload-store-pairs

Message ID 6D39441BF12EF246A7ABCE6654B0235380B75FA6@hhmail02.hh.imgtec.org
State New
Headers show

Commit Message

Matthew Fortune Feb. 24, 2017, 1:57 p.m. UTC
Hi Catherine,

Can you review the description for -mload-store-pairs please?

Thanks,
Matthew

gcc/
	PR target/79473
	* doc/invoke.texi: Document -mload-store-pairs.

Comments

Moore, Catherine Feb. 24, 2017, 3:48 p.m. UTC | #1
> -----Original Message-----
> From: Matthew Fortune [mailto:Matthew.Fortune@imgtec.com]
> Sent: Friday, February 24, 2017 8:58 AM
> To: Moore, Catherine <Catherine_Moore@mentor.com>
> Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) <gcc-
> patches@gcc.gnu.org>
> Subject: [PATCH,MIPS] Document -mload-store-pairs
> 
> Hi Catherine,
> 
> Can you review the description for -mload-store-pairs please?
> 
> Thanks,
> Matthew
> 
> gcc/
> 	PR target/79473
> 	* doc/invoke.texi: Document -mload-store-pairs.
> 
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 6e5fa56..f1fc449 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -879,6 +879,7 @@ Objective-C and Objective-C++ Dialects}.
>  -mexplicit-relocs  -mno-explicit-relocs @gol
>  -mcheck-zero-division  -mno-check-zero-division @gol
>  -mdivide-traps  -mdivide-breaks @gol
> +-mload-store-pairs  -mno-load-store-pairs @gol
>  -mmemcpy  -mno-memcpy  -mlong-calls  -mno-long-calls @gol
>  -mmad  -mno-mad  -mimadd  -mno-imadd  -mfused-madd  -mno-fused-
> madd  -nocpp @gol
>  -mfix-24k  -mno-fix-24k @gol
> @@ -19495,6 +19496,16 @@ overridden at configure time using
> @option{--with-divide=breaks}.
>  Divide-by-zero checks can be completely disabled using
>  @option{-mno-check-zero-division}.
> 
> +@item -mload-store-pairs
> +@itemx -mno-load-store-pairs
> +@opindex mload-store-pairs
> +@opindex mno-load-store-pairs
> +Enable (disable) an optimization that keeps consecutive load or store
> +instructions sequential to allow MIPS processors that perform load
> +and store bonding to optimize the access.  This option is enabled by
> +default but only takes effect when the selected architecture is known
> +to support bonding.
> +
>  @item -mmemcpy
>  @itemx -mno-memcpy
>  @opindex mmemcpy
> --
> 2.2.1

Hi Matthew -- How about this instead?

+@item -mload-store-pairs
+@itemx -mno-load-store-pairs
+@opindex mload-store-pairs
+@opindex mno-load-store-pairs
+Enable (disable) an optimization that pairs consecutive load or store
+instructions to enable load/store bonding.  This option is enabled by
+default but only takes effect when the selected architecture is known
+to support bonding.
+
Matthew Fortune Feb. 24, 2017, 4:08 p.m. UTC | #2
Moore, Catherine <Catherine_Moore@mentor.com> writes:
> > -----Original Message-----
> > From: Matthew Fortune [mailto:Matthew.Fortune@imgtec.com]
> > Sent: Friday, February 24, 2017 8:58 AM
> > To: Moore, Catherine <Catherine_Moore@mentor.com>
> > Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) <gcc-
> > patches@gcc.gnu.org>
> > Subject: [PATCH,MIPS] Document -mload-store-pairs
> >
> > Hi Catherine,
> >
> > Can you review the description for -mload-store-pairs please?
> >
> > Thanks,
> > Matthew
> >
> > gcc/
> > 	PR target/79473
> > 	* doc/invoke.texi: Document -mload-store-pairs.
> >
> > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> > index 6e5fa56..f1fc449 100644
> > --- a/gcc/doc/invoke.texi
> > +++ b/gcc/doc/invoke.texi
> > @@ -879,6 +879,7 @@ Objective-C and Objective-C++ Dialects}.
> >  -mexplicit-relocs  -mno-explicit-relocs @gol
> >  -mcheck-zero-division  -mno-check-zero-division @gol
> >  -mdivide-traps  -mdivide-breaks @gol
> > +-mload-store-pairs  -mno-load-store-pairs @gol
> >  -mmemcpy  -mno-memcpy  -mlong-calls  -mno-long-calls @gol
> >  -mmad  -mno-mad  -mimadd  -mno-imadd  -mfused-madd  -mno-fused-
> > madd  -nocpp @gol
> >  -mfix-24k  -mno-fix-24k @gol
> > @@ -19495,6 +19496,16 @@ overridden at configure time using
> > @option{--with-divide=breaks}.
> >  Divide-by-zero checks can be completely disabled using
> >  @option{-mno-check-zero-division}.
> >
> > +@item -mload-store-pairs
> > +@itemx -mno-load-store-pairs
> > +@opindex mload-store-pairs
> > +@opindex mno-load-store-pairs
> > +Enable (disable) an optimization that keeps consecutive load or store
> > +instructions sequential to allow MIPS processors that perform load
> > +and store bonding to optimize the access.  This option is enabled by
> > +default but only takes effect when the selected architecture is known
> > +to support bonding.
> > +
> >  @item -mmemcpy
> >  @itemx -mno-memcpy
> >  @opindex mmemcpy
> > --
> > 2.2.1
> 
> Hi Matthew -- How about this instead?
> 
> +@item -mload-store-pairs
> +@itemx -mno-load-store-pairs
> +@opindex mload-store-pairs
> +@opindex mno-load-store-pairs
> +Enable (disable) an optimization that pairs consecutive load or store
> +instructions to enable load/store bonding.  This option is enabled by
> +default but only takes effect when the selected architecture is known
> +to support bonding.
> +

Sure, I'll commit this along with the paired single fix when you've had
chance to review.

Thanks,
Matthew
diff mbox

Patch

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 6e5fa56..f1fc449 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -879,6 +879,7 @@  Objective-C and Objective-C++ Dialects}.
 -mexplicit-relocs  -mno-explicit-relocs @gol
 -mcheck-zero-division  -mno-check-zero-division @gol
 -mdivide-traps  -mdivide-breaks @gol
+-mload-store-pairs  -mno-load-store-pairs @gol
 -mmemcpy  -mno-memcpy  -mlong-calls  -mno-long-calls @gol
 -mmad  -mno-mad  -mimadd  -mno-imadd  -mfused-madd  -mno-fused-madd  -nocpp @gol
 -mfix-24k  -mno-fix-24k @gol
@@ -19495,6 +19496,16 @@  overridden at configure time using @option{--with-divide=breaks}.
 Divide-by-zero checks can be completely disabled using
 @option{-mno-check-zero-division}.
 
+@item -mload-store-pairs
+@itemx -mno-load-store-pairs
+@opindex mload-store-pairs
+@opindex mno-load-store-pairs
+Enable (disable) an optimization that keeps consecutive load or store
+instructions sequential to allow MIPS processors that perform load
+and store bonding to optimize the access.  This option is enabled by
+default but only takes effect when the selected architecture is known
+to support bonding.
+
 @item -mmemcpy
 @itemx -mno-memcpy
 @opindex mmemcpy