Patchwork [5/7] usb-linux: Refuse iso packets when max packet size is 0 (alt setting 0)

login
register
mail settings
Submitter Hans de Goede
Date Nov. 26, 2010, 6:13 p.m.
Message ID <1290795203-2597-5-git-send-email-hdegoede@redhat.com>
Download mbox | patch
Permalink /patch/73213/
State New
Headers show

Comments

Hans de Goede - Nov. 26, 2010, 6:13 p.m.
Refuse iso usb packets when then max packet size for the endpoint is 0,
this avoids an abort in usb_host_alloc_iso() caused by trying to qemu_malloc
a 0 bytes large buffer.
---
 usb-linux.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

Patch

diff --git a/usb-linux.c b/usb-linux.c
index 8513ace..5a979bd 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -548,7 +548,11 @@  static int urb_status_to_usb_ret(int status)
 static int usb_host_handle_iso_data(USBHostDevice *s, USBPacket *p)
 {
     AsyncURB *aurb;
-    int i, j, ret, len = 0;
+    int i, j, ret, max_packet_size, len = 0;
+
+    max_packet_size = get_max_packet_size(s, p->devep);
+    if (max_packet_size == 0)
+        return USB_RET_NAK;
 
     aurb = get_iso_urb(s, p->devep);
     if (!aurb) {