[U-Boot,3/3] rockchip: rk3188: drop CONFIG_SYS_NO_FLASH
diff mbox

Message ID 20170223163040.9303-3-heiko@sntech.de
State Accepted
Commit 0e27248388a010b38858bdd592fa38f8b0c46e32
Delegated to: Simon Glass
Headers show

Commit Message

Heiko Stuebner Feb. 23, 2017, 4:30 p.m. UTC
Commit e856bdcfb492 ("flash: complete CONFIG_SYS_NO_FLASH move with renaming")
obsoleted the CONFIG_SYS_NO_FLASH option, which still is in our
rk3188_common.h header, resulting in warnings like
    The following new ad-hoc CONFIG options were detected:
    CONFIG_SYS_NO_FLASH

So also drop it from the rk3188 header.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 include/configs/rk3188_common.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Glass March 3, 2017, 4:52 a.m. UTC | #1
On 23 February 2017 at 09:30, Heiko Stuebner <heiko@sntech.de> wrote:
> Commit e856bdcfb492 ("flash: complete CONFIG_SYS_NO_FLASH move with renaming")
> obsoleted the CONFIG_SYS_NO_FLASH option, which still is in our
> rk3188_common.h header, resulting in warnings like
>     The following new ad-hoc CONFIG options were detected:
>     CONFIG_SYS_NO_FLASH
>
> So also drop it from the rk3188 header.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  include/configs/rk3188_common.h | 1 -
>  1 file changed, 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass March 14, 2017, 11:50 p.m. UTC | #2
On 2 March 2017 at 21:52, Simon Glass <sjg@chromium.org> wrote:
> On 23 February 2017 at 09:30, Heiko Stuebner <heiko@sntech.de> wrote:
>> Commit e856bdcfb492 ("flash: complete CONFIG_SYS_NO_FLASH move with renaming")
>> obsoleted the CONFIG_SYS_NO_FLASH option, which still is in our
>> rk3188_common.h header, resulting in warnings like
>>     The following new ad-hoc CONFIG options were detected:
>>     CONFIG_SYS_NO_FLASH
>>
>> So also drop it from the rk3188 header.
>>
>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> ---
>>  include/configs/rk3188_common.h | 1 -
>>  1 file changed, 1 deletion(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!

Patch
diff mbox

diff --git a/include/configs/rk3188_common.h b/include/configs/rk3188_common.h
index 445b2da496..2ff7cd7b70 100644
--- a/include/configs/rk3188_common.h
+++ b/include/configs/rk3188_common.h
@@ -13,7 +13,6 @@ 
 #include "rockchip-common.h"
 
 #define CONFIG_SKIP_LOWLEVEL_INIT_ONLY
-#define CONFIG_SYS_NO_FLASH
 #define CONFIG_NR_DRAM_BANKS		1
 #define CONFIG_ENV_SIZE			0x2000
 #define CONFIG_SYS_MAXARGS		16