Patchwork [U-Boot] ppc4xx/POST: Handle cached SDRAM correctly in Denali (440EPx) ECC POST

login
register
mail settings
Submitter Stefan Roese
Date Nov. 26, 2010, 2:45 p.m.
Message ID <1290782722-9459-1-git-send-email-sr@denx.de>
Download mbox | patch
Permalink /patch/73187/
State Accepted
Commit 28e94bb2f7b796f58587752ab018b7d23fdc9061
Headers show

Comments

Stefan Roese - Nov. 26, 2010, 2:45 p.m.
This patch fixes a problem in the Denali (440EPx) SDRAM ECC POST test.
When cache is enabled in the SDRAM area, the values written to SDRAM
need to be flushed from cache to SDRAM using the dcfb instruction.

Without this patch the POST ECC test failed. Now its working again on
platforms with cache enabled in SDRAM.

Signed-off-by: Stefan Roese <sr@denx.de>
---
 post/cpu/ppc4xx/denali_ecc.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Stefan Roese - Nov. 28, 2010, 10:07 a.m.
On Friday 26 November 2010 15:45:22 Stefan Roese wrote:
> This patch fixes a problem in the Denali (440EPx) SDRAM ECC POST test.
> When cache is enabled in the SDRAM area, the values written to SDRAM
> need to be flushed from cache to SDRAM using the dcfb instruction.
> 
> Without this patch the POST ECC test failed. Now its working again on
> platforms with cache enabled in SDRAM.

Applied to u-boot-ppc4xx/master. Thanks.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de

Patch

diff --git a/post/cpu/ppc4xx/denali_ecc.c b/post/cpu/ppc4xx/denali_ecc.c
index 50ae7fb..6d14635 100644
--- a/post/cpu/ppc4xx/denali_ecc.c
+++ b/post/cpu/ppc4xx/denali_ecc.c
@@ -174,6 +174,7 @@  static int test_ecc(uint32_t ecc_addr)
 	clear_and_enable_ecc();
 	out_be32(ecc_mem, ECC_PATTERN);
 	out_be32(ecc_mem + 1, ECC_PATTERN);
+	ppcDcbf((u32)ecc_mem);
 
 	/* Verify no ECC error reading back */
 	value = in_be32(ecc_mem);
@@ -193,6 +194,7 @@  static int test_ecc(uint32_t ecc_addr)
 
 	/* Test for correctable error by creating a one-bit error */
 	out_be32(ecc_mem, ECC_PATTERN_CORR);
+	ppcDcbf((u32)ecc_mem);
 	clear_and_enable_ecc();
 	value = in_be32(ecc_mem);
 	disable_ecc();
@@ -212,6 +214,7 @@  static int test_ecc(uint32_t ecc_addr)
 
 	/* Test for uncorrectable error by creating a two-bit error */
 	out_be32(ecc_mem, ECC_PATTERN_UNCORR);
+	ppcDcbf((u32)ecc_mem);
 	clear_and_enable_ecc();
 	value = in_be32(ecc_mem);
 	disable_ecc();
@@ -232,6 +235,7 @@  static int test_ecc(uint32_t ecc_addr)
 
 	/* Remove error from SDRAM and enable ECC. */
 	out_be32(ecc_mem, ECC_PATTERN);
+	ppcDcbf((u32)ecc_mem);
 	clear_and_enable_ecc();
 
 	return ret;