Patchwork [U-Boot] usb: Remove usb_dev_init() from ehci-ppc4xx.c

login
register
mail settings
Submitter Stefan Roese
Date Nov. 26, 2010, 2:43 p.m.
Message ID <1290782624-9073-1-git-send-email-sr@denx.de>
Download mbox | patch
Permalink /patch/73185/
State Accepted
Commit a42a9d71b58a789d3c4a1fbfbf400f65699a2689
Delegated to: Remy Bohmer
Headers show

Comments

Stefan Roese - Nov. 26, 2010, 2:43 p.m.
Calling usb_dev_init() from within the EHCI host driver is wrong.
The EHCI host driver should have no dependency/interconnection to the
USB device driver.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Remy Bohmer <linux@bohmer.net>
---
 drivers/usb/host/ehci-ppc4xx.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Remy Bohmer - Nov. 26, 2010, 8:25 p.m.
Hi,

2010/11/26 Stefan Roese <sr@denx.de>:
> Calling usb_dev_init() from within the EHCI host driver is wrong.
> The EHCI host driver should have no dependency/interconnection to the
> USB device driver.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Remy Bohmer <linux@bohmer.net>
> ---
>  drivers/usb/host/ehci-ppc4xx.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Applied to u-boot-usb. Thanks.

Kind regards,

Remy

Patch

diff --git a/drivers/usb/host/ehci-ppc4xx.c b/drivers/usb/host/ehci-ppc4xx.c
index 946a0a0..1179919 100644
--- a/drivers/usb/host/ehci-ppc4xx.c
+++ b/drivers/usb/host/ehci-ppc4xx.c
@@ -34,7 +34,6 @@  int ehci_hcd_init(void)
 	hccr = (struct ehci_hccr *)(CONFIG_SYS_PPC4XX_USB_ADDR);
 	hcor = (struct ehci_hcor *)((uint32_t) hccr +
 		HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
-	usb_dev_init();
 	return 0;
 }