Patchwork [U-Boot] usb: Add WATCHDOG_RESET call to polling loop

login
register
mail settings
Submitter Stefan Roese
Date Nov. 26, 2010, 2:43 p.m.
Message ID <1290782608-8972-1-git-send-email-sr@denx.de>
Download mbox | patch
Permalink /patch/73183/
State Accepted
Commit 67333f76b683cb19762c60f180a4e9c592064fc1
Delegated to: Remy Bohmer
Headers show

Comments

Stefan Roese - Nov. 26, 2010, 2:43 p.m.
This watchdog reset call is needed here, otherwise the lwmon5 board
(PPC440EPx based) will reset upon the "usb reset" command.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Remy Bohmer <linux@bohmer.net>
---
 drivers/usb/host/ehci-hcd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Remy Bohmer - Nov. 26, 2010, 8:22 p.m.
Hi,

2010/11/26 Stefan Roese <sr@denx.de>:
> This watchdog reset call is needed here, otherwise the lwmon5 board
> (PPC440EPx based) will reset upon the "usb reset" command.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Remy Bohmer <linux@bohmer.net>
> ---
>  drivers/usb/host/ehci-hcd.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 982f96e..b88488e 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c

Applied to u-boot-usb. Thanks.

Kind regards,

Remy

Patch

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 982f96e..b88488e 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -25,6 +25,7 @@ 
 #include <usb.h>
 #include <asm/io.h>
 #include <malloc.h>
+#include <watchdog.h>
 
 #include "ehci.h"
 
@@ -452,6 +453,7 @@  ehci_submit_async(struct usb_device *dev, unsigned long pipe, void *buffer,
 		token = hc32_to_cpu(vtd->qt_token);
 		if (!(token & 0x80))
 			break;
+		WATCHDOG_RESET();
 	} while (get_timer(ts) < CONFIG_SYS_HZ);
 
 	/* Disable async schedule. */