| Message ID | 1487886317-27400-10-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 02/23/2017 03:45 PM, Markus Armbruster wrote: > The QObject input visitor has three error message formats: > > * Parameter '%s' is missing > * "Invalid parameter type for '%s', expected: %s" > * "QMP input object member '%s' is unexpected" > > The '%s' are member names (or "null", but I'll fix that later). > > The last error message calls the thing "QMP input object member" > instead of "parameter". Misleading when the visitor is used on > QObjects that don't come from QMP. Change it to "Parameter '%s' is > unexpected". > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > qapi/qobject-input-visitor.c | 3 +-- > tests/test-qga.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c index ed6c24c..f3b6713 100644 --- a/qapi/qobject-input-visitor.c +++ b/qapi/qobject-input-visitor.c @@ -140,8 +140,7 @@ static void qobject_input_check_struct(Visitor *v, Error **errp) g_hash_table_iter_init(&iter, top_ht); if (g_hash_table_iter_next(&iter, (void **)&key, NULL)) { - error_setg(errp, "QMP input object member '%s' is unexpected", - key); + error_setg(errp, "Parameter '%s' is unexpected", key); } } } diff --git a/tests/test-qga.c b/tests/test-qga.c index 868b02a..ae97b57 100644 --- a/tests/test-qga.c +++ b/tests/test-qga.c @@ -213,7 +213,7 @@ static void test_qga_invalid_args(gconstpointer fix) desc = qdict_get_try_str(error, "desc"); g_assert_cmpstr(class, ==, "GenericError"); - g_assert_cmpstr(desc, ==, "QMP input object member 'foo' is unexpected"); + g_assert_cmpstr(desc, ==, "Parameter 'foo' is unexpected"); QDECREF(ret); }
The QObject input visitor has three error message formats: * Parameter '%s' is missing * "Invalid parameter type for '%s', expected: %s" * "QMP input object member '%s' is unexpected" The '%s' are member names (or "null", but I'll fix that later). The last error message calls the thing "QMP input object member" instead of "parameter". Misleading when the visitor is used on QObjects that don't come from QMP. Change it to "Parameter '%s' is unexpected". Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qapi/qobject-input-visitor.c | 3 +-- tests/test-qga.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)