| Message ID | 1487843865-2253-1-git-send-email-jiri@resnulli.us |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Jiri, On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote: > From: Jiri Pirko <jiri@mellanox.com> > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. Thanks! > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: 44091d29f207 ("lib: Introduce priority array area manager") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
From: Jiri Pirko <jiri@resnulli.us> Date: Thu, 23 Feb 2017 10:57:45 +0100 > From: Jiri Pirko <jiri@mellanox.com> > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: 44091d29f207 ("lib: Introduce priority array area manager") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> Applied.
Hi Jiri, On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote: > From: Jiri Pirko <jiri@mellanox.com> > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> > Fixes: 44091d29f207 ("lib: Introduce priority array area manager") > Signed-off-by: Jiri Pirko <jiri@mellanox.com> > --- > lib/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index 5d644f1..f355260 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -551,6 +551,6 @@ config SBITMAP > bool > > config PARMAN > - tristate "parman" > + tristate Upon second thought tristate "parman" if COMPILE_TEST might be better, as it allows to enable and run the accompanying test without dependencies. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Fri, Feb 24, 2017 at 08:54:04AM CET, geert@linux-m68k.org wrote: >Hi Jiri, > >On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote: >> From: Jiri Pirko <jiri@mellanox.com> >> >> As reported by Geert, remove the string so the user does not see this >> config option. The option is explicitly selected only as a dependency of >> in-kernel users. >> >> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Fixes: 44091d29f207 ("lib: Introduce priority array area manager") >> Signed-off-by: Jiri Pirko <jiri@mellanox.com> >> --- >> lib/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/Kconfig b/lib/Kconfig >> index 5d644f1..f355260 100644 >> --- a/lib/Kconfig >> +++ b/lib/Kconfig >> @@ -551,6 +551,6 @@ config SBITMAP >> bool >> >> config PARMAN >> - tristate "parman" >> + tristate > >Upon second thought > > tristate "parman" if COMPILE_TEST > >might be better, as it allows to enable and run the accompanying test without >dependencies. > >Gr{oetje,eeting}s, > > Geert Geert, could you please send this as a follow-up? Thanks.
Hi Jiri, On Fri, Feb 24, 2017 at 9:25 AM, Jiri Pirko <jiri@resnulli.us> wrote: > Fri, Feb 24, 2017 at 08:54:04AM CET, geert@linux-m68k.org wrote: >>On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko <jiri@resnulli.us> wrote: >>> From: Jiri Pirko <jiri@mellanox.com> >>> >>> As reported by Geert, remove the string so the user does not see this >>> config option. The option is explicitly selected only as a dependency of >>> in-kernel users. >>> >>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> >>> Fixes: 44091d29f207 ("lib: Introduce priority array area manager") >>> Signed-off-by: Jiri Pirko <jiri@mellanox.com> >>> --- >>> lib/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/lib/Kconfig b/lib/Kconfig >>> index 5d644f1..f355260 100644 >>> --- a/lib/Kconfig >>> +++ b/lib/Kconfig >>> @@ -551,6 +551,6 @@ config SBITMAP >>> bool >>> >>> config PARMAN >>> - tristate "parman" >>> + tristate >> >>Upon second thought >> >> tristate "parman" if COMPILE_TEST >> >>might be better, as it allows to enable and run the accompanying test without >>dependencies. > > Geert, could you please send this as a follow-up? Thanks. Sure, will do. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/lib/Kconfig b/lib/Kconfig index 5d644f1..f355260 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -551,6 +551,6 @@ config SBITMAP bool config PARMAN - tristate "parman" + tristate endmenu