| Message ID | 1487796146-14690-3-git-send-email-steven.lin1@broadcom.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, Feb 22, 2017 at 3:42 PM, Steve Lin <steven.lin1@broadcom.com> wrote: > Adds mailbox / PDC to NSP device tree. Needs new compatibility string > to differentiate from NS2 version. > > Signed-off-by: Steve Lin <steven.lin1@broadcom.com> > --- > .../devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt | 6 ++++-- > arch/arm/boot/dts/bcm-nsp.dtsi | 9 +++++++++ I believe it is preferred to have a separate patch for the binding documentation. Aside from that, it looks fine to me. Thanks, Jon > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > index 411ccf4..0f3ee81 100644 > --- a/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > +++ b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt > @@ -1,9 +1,11 @@ > The PDC driver manages data transfer to and from various offload engines > on some Broadcom SoCs. An SoC may have multiple PDC hardware blocks. There is > -one device tree entry per block. > +one device tree entry per block. On some chips, the PDC functionality is > +handled by the FA2 (Northstar Plus). > > Required properties: > -- compatible : Should be "brcm,iproc-pdc-mbox". > +- compatible : Should be "brcm,iproc-pdc-mbox" or "brcm,iproc-fa2-mbox" for > + FA2/Northstar Plus. > - reg: Should contain PDC registers location and length. > - interrupts: Should contain the IRQ line for the PDC. > - #mbox-cells: 1 > diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi > index 15f07f9..8b56d74 100644 > --- a/arch/arm/boot/dts/bcm-nsp.dtsi > +++ b/arch/arm/boot/dts/bcm-nsp.dtsi > @@ -227,6 +227,15 @@ > status = "disabled"; > }; > > + mailbox: mailbox@25000 { > + compatible = "brcm,iproc-fa2-mbox"; > + reg = <0x25000 0x445>; > + interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>; > + #mbox-cells = <1>; > + brcm,rx-status-len = <32>; > + brcm,use-bcm-hdr; > + }; > + > nand: nand@26000 { > compatible = "brcm,nand-iproc", "brcm,brcmnand-v6.1"; > reg = <0x026000 0x600>, > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 22, 2017 at 03:42:26PM -0500, Steve Lin wrote: > Adds mailbox / PDC to NSP device tree. Needs new compatibility string > to differentiate from NS2 version. > > Signed-off-by: Steve Lin <steven.lin1@broadcom.com> > --- > .../devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt | 6 ++++-- > arch/arm/boot/dts/bcm-nsp.dtsi | 9 +++++++++ > 2 files changed, 13 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt index 411ccf4..0f3ee81 100644 --- a/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt +++ b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt @@ -1,9 +1,11 @@ The PDC driver manages data transfer to and from various offload engines on some Broadcom SoCs. An SoC may have multiple PDC hardware blocks. There is -one device tree entry per block. +one device tree entry per block. On some chips, the PDC functionality is +handled by the FA2 (Northstar Plus). Required properties: -- compatible : Should be "brcm,iproc-pdc-mbox". +- compatible : Should be "brcm,iproc-pdc-mbox" or "brcm,iproc-fa2-mbox" for + FA2/Northstar Plus. - reg: Should contain PDC registers location and length. - interrupts: Should contain the IRQ line for the PDC. - #mbox-cells: 1 diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi index 15f07f9..8b56d74 100644 --- a/arch/arm/boot/dts/bcm-nsp.dtsi +++ b/arch/arm/boot/dts/bcm-nsp.dtsi @@ -227,6 +227,15 @@ status = "disabled"; }; + mailbox: mailbox@25000 { + compatible = "brcm,iproc-fa2-mbox"; + reg = <0x25000 0x445>; + interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>; + #mbox-cells = <1>; + brcm,rx-status-len = <32>; + brcm,use-bcm-hdr; + }; + nand: nand@26000 { compatible = "brcm,nand-iproc", "brcm,brcmnand-v6.1"; reg = <0x026000 0x600>,
Adds mailbox / PDC to NSP device tree. Needs new compatibility string to differentiate from NS2 version. Signed-off-by: Steve Lin <steven.lin1@broadcom.com> --- .../devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt | 6 ++++-- arch/arm/boot/dts/bcm-nsp.dtsi | 9 +++++++++ 2 files changed, 13 insertions(+), 2 deletions(-)