From patchwork Thu Nov 25 17:31:23 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 73109 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2E5CAB70D4 for ; Fri, 26 Nov 2010 04:42:19 +1100 (EST) Received: from localhost ([127.0.0.1]:36894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLfpj-0005LP-5k for incoming@patchwork.ozlabs.org; Thu, 25 Nov 2010 12:42:11 -0500 Received: from [140.186.70.92] (port=57772 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLfkR-00035D-LO for qemu-devel@nongnu.org; Thu, 25 Nov 2010 12:36:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLfkP-0005P5-IJ for qemu-devel@nongnu.org; Thu, 25 Nov 2010 12:36:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLfkP-0005Ot-6u for qemu-devel@nongnu.org; Thu, 25 Nov 2010 12:36:41 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAPHadRT008068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 25 Nov 2010 12:36:39 -0500 Received: from localhost ([10.3.113.14]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAPHabDw024377; Thu, 25 Nov 2010 12:36:38 -0500 From: Amit Shah To: Anthony Liguori Date: Thu, 25 Nov 2010 23:01:23 +0530 Message-Id: <16bc7e2dee53c9f43f50471615582d8aeb0ab4b3.1290706012.git.amit.shah@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Amit Shah , Kevin Wolf , qemu list Subject: [Qemu-devel] [PATCH 4/4] block_int.h: Provide documentation for common block qdev properties X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Document the options common to all block devices. This comes from Kevin. Signed-off-by: Amit Shah CC: Kevin Wolf --- block_int.h | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/block_int.h b/block_int.h index 88a2546..867c4e2 100644 --- a/block_int.h +++ b/block_int.h @@ -243,12 +243,14 @@ static inline unsigned int get_physical_block_exp(BlockConf *conf) } #define DEFINE_BLOCK_PROPERTIES(_state, _conf) \ - DEFINE_PROP_DRIVE("drive", _state, _conf.bs, ""), \ - DEFINE_PROP_UINT16("logical_block_size", _state, \ - _conf.logical_block_size, 512, ""), \ + DEFINE_PROP_DRIVE("drive", _state, _conf.bs, "The host drive details, specified by the -drive parameter"), \ + DEFINE_PROP_UINT16("logical_block_size", _state, _conf.logical_block_size, \ + 512, "Logical sector size of the disk"), \ DEFINE_PROP_UINT16("physical_block_size", _state, \ - _conf.physical_block_size, 512, ""), \ - DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0, ""), \ - DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0, "") + _conf.physical_block_size, 512, "Physical sector size of the disk"), \ + DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0, \ + "Minimal size for IO requests in bytes. Must be a power of two that is 512 or greater."), \ + DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0, \ + "Size for IO requests that provides optimal performance (in bytes). Must be a power of two that is 512 or greater.") #endif /* BLOCK_INT_H */