| Message ID | 20170222100718.23249-3-wenyou.yang@atmel.com |
|---|---|
| State | Accepted |
| Commit | 0de077df38a6a1120acf7833572d1ffc8f209f33 |
| Delegated to: | Andreas Bießmann |
| Headers | show |
On 22 February 2017 at 03:07, Wenyou Yang <wenyou.yang@atmel.com> wrote: > Because there is no implementation of gpio_set/get_value() function > after the at91 gpio driver is converted to support DM, use > at91_set/get_gpio_value(). > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > --- > > drivers/mtd/nand/atmel_nand.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> At some point this should change to use driver model, right?
Hi Simon, > -----Original Message----- > From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass > Sent: 2017年3月3日 12:52 > To: Wenyou Yang - A41535 <Wenyou.Yang@microchip.com> > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Andreas Bießmann > <andreas@biessmann.org>; Scott Wood <scottwood@freescale.com>; Wenyou > Yang - A41535 <Wenyou.Yang@microchip.com> > Subject: Re: [PATCH 2/2] mtd: nand: atmel: change another functions to set/get > gpio value > > On 22 February 2017 at 03:07, Wenyou Yang <wenyou.yang@atmel.com> wrote: > > Because there is no implementation of gpio_set/get_value() function > > after the at91 gpio driver is converted to support DM, use > > at91_set/get_gpio_value(). > > > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > > --- > > > > drivers/mtd/nand/atmel_nand.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > At some point this should change to use driver model, right? Yes, after the NAND uclass Implementation patches are accepted by main-line, Atmel nand driver will be converted to support driver model. Best Regards, Wenyou Yang
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index 8669432deb..21d5d0e70d 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -1222,7 +1222,8 @@ static void at91_nand_hwcontrol(struct mtd_info *mtd, IO_ADDR_W |= CONFIG_SYS_NAND_MASK_ALE; #ifdef CONFIG_SYS_NAND_ENABLE_PIN - gpio_set_value(CONFIG_SYS_NAND_ENABLE_PIN, !(ctrl & NAND_NCE)); + at91_set_gpio_value(CONFIG_SYS_NAND_ENABLE_PIN, + !(ctrl & NAND_NCE)); #endif this->IO_ADDR_W = (void *) IO_ADDR_W; } @@ -1234,7 +1235,7 @@ static void at91_nand_hwcontrol(struct mtd_info *mtd, #ifdef CONFIG_SYS_NAND_READY_PIN static int at91_nand_ready(struct mtd_info *mtd) { - return gpio_get_value(CONFIG_SYS_NAND_READY_PIN); + return at91_get_gpio_value(CONFIG_SYS_NAND_READY_PIN); } #endif
Because there is no implementation of gpio_set/get_value() function after the at91 gpio driver is converted to support DM, use at91_set/get_gpio_value(). Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> --- drivers/mtd/nand/atmel_nand.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)