| Message ID | 20170222100718.23249-2-wenyou.yang@atmel.com |
|---|---|
| State | Accepted |
| Commit | 8c4e4101d68ca075bba641c88a398ee8ed81b07f |
| Delegated to: | Andreas Bießmann |
| Headers | show |
Hi Wenyou, On 22 February 2017 at 03:07, Wenyou Yang <wenyou.yang@atmel.com> wrote: > There is no implementation on at91_set_pio_value() with two arguments. > at91_get_pio_value() with one argument. > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > --- > > arch/arm/mach-at91/include/mach/gpio.h | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) I cannot make sense of this commit message. It should explain what the commit does. Regards, Simon
diff --git a/arch/arm/mach-at91/include/mach/gpio.h b/arch/arm/mach-at91/include/mach/gpio.h index 5a32bdba8d..df0f71975a 100644 --- a/arch/arm/mach-at91/include/mach/gpio.h +++ b/arch/arm/mach-at91/include/mach/gpio.h @@ -223,15 +223,13 @@ static inline unsigned pin_to_mask(unsigned pin) at91_set_pio_output((x - PIN_BASE) / 32,(x % 32), y) #define at91_set_gpio_input(x, y) \ at91_set_pio_input((x - PIN_BASE) / 32,(x % 32), y) -#define at91_set_gpio_value(x, y) \ - at91_set_pio_value((x - PIN_BASE) / 32,(x % 32), y) -#define at91_get_gpio_value(x) \ - at91_get_pio_value((x - PIN_BASE) / 32,(x % 32)) -#else -#define at91_set_gpio_value(x, y) at91_set_pio_value(x, y) -#define at91_get_gpio_value(x) at91_get_pio_value(x) #endif +#define at91_set_gpio_value(x, y) \ + at91_set_pio_value((x / 32), (x % 32), y) +#define at91_get_gpio_value(x) \ + at91_get_pio_value((x / 32), (x % 32)) + #define GPIO_PIOA_BASE (0) #define GPIO_PIOB_BASE (GPIO_PIOA_BASE + 32) #define GPIO_PIOC_BASE (GPIO_PIOB_BASE + 32)
There is no implementation on at91_set_pio_value() with two arguments. at91_get_pio_value() with one argument. Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> --- arch/arm/mach-at91/include/mach/gpio.h | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)