| Message ID | 20170222031423.GA2574@csmart.io |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Wed, 22 Feb 2017 14:14:23 +1100, Chris Smart wrote: > Currently the host build of Python 2 defaults to narrow unicode (UCS2), > ignoring the BR2_PACKAGE_PYTHON_UCS4 configuration option which may be > set to wide (UCS4). > > This results in host and target Python packages which are incompatible > in subtle ways. > > For example, installing wheels into the target fails when they are made > with the host python, citing incompatibility (as can be seen by the > package tags which may be "cp27u-manylinux1" instead of > "cp27mu-manylinux1"). > > Compiling the host Python 2 with the same UCS configuration as the > target ensures that the packages are compatible (and the tags match). > > This does not affect Python 3 as support for narrow unicode was > deprecated in version 3.3, see https://www.python.org/dev/peps/pep-0393/ > > Thanks to Tony Breeds <tony@bakeyournoodle.com> for reporting this. > > Signed-off-by: Chris Smart <mail@csmart.io> > --- > package/python/python.mk | 1 + > 1 file changed, 1 insertion(+) Applied to master, after adding a comment in the code itself to explain why we're doing this. Thanks! Thomas
On Thu, Feb 23, 2017 at 11:13:37PM +0100, Thomas Petazzoni wrote: >Applied to master, after adding a comment in the code itself >to explain >why we're doing this. Great, thanks Thomas! Cheers, -c
diff --git a/package/python/python.mk b/package/python/python.mk index 7b20434c94c2b8b8..330716d57f3712f1 100644 --- a/package/python/python.mk +++ b/package/python/python.mk @@ -105,6 +105,7 @@ endif # Default is UCS2 w/o a conf opt ifeq ($(BR2_PACKAGE_PYTHON_UCS4),y) +HOST_PYTHON_CONF_OPTS += --enable-unicode=ucs4 PYTHON_CONF_OPTS += --enable-unicode=ucs4 endif
Currently the host build of Python 2 defaults to narrow unicode (UCS2), ignoring the BR2_PACKAGE_PYTHON_UCS4 configuration option which may be set to wide (UCS4). This results in host and target Python packages which are incompatible in subtle ways. For example, installing wheels into the target fails when they are made with the host python, citing incompatibility (as can be seen by the package tags which may be "cp27u-manylinux1" instead of "cp27mu-manylinux1"). Compiling the host Python 2 with the same UCS configuration as the target ensures that the packages are compatible (and the tags match). This does not affect Python 3 as support for narrow unicode was deprecated in version 3.3, see https://www.python.org/dev/peps/pep-0393/ Thanks to Tony Breeds <tony@bakeyournoodle.com> for reporting this. Signed-off-by: Chris Smart <mail@csmart.io> --- package/python/python.mk | 1 + 1 file changed, 1 insertion(+)