mbox

[PULL,v2,0/8] target-mips queue

Message ID 1487722868-9111-1-git-send-email-yongbok.kim@imgtec.com
State New
Headers show

Pull-request

git://github.com/yongbok/upstream-qemu.git tags/mips-20170222

Message

Yongbok Kim Feb. 22, 2017, 12:21 a.m. UTC
Hi,

This is the v2 of the pull-req for target-mips.
The warning treated as error has been fixed and the file is now isolated for mips64el only.
Boston has further update to have default -drive to if=ide. 

Regards,
Yongbok

The following changes since commit 796b288f7be875045670f963ce99991b3c8e96ac:

  Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2017-02-21 15:48:22 +0000)

are available in the git repository at:

  git://github.com/yongbok/upstream-qemu.git tags/mips-20170222

for you to fetch changes up to d3473e147a754e999718bf6fcb015d9978c6a1ee:

  hw/mips: MIPS Boston board support (2017-02-21 23:49:30 +0000)

----------------------------------------------------------------
MIPS patches 2017-02-22

Changes:
* Add MIPS Boston board support

----------------------------------------------------------------

Paul Burton (8):
  hw/mips_cmgcr: allow GCR base to be moved
  hw/mips_gictimer: provide API for retrieving frequency
  hw/mips_gic: Update pin state on mask changes
  target-mips: Provide function to test if a CPU supports an ISA
  dtc: Update requirement to v1.4.2
  loader: Support Flattened Image Trees (FIT images)
  hw: xilinx-pcie: Add support for Xilinx AXI PCIe Controller
  hw/mips: MIPS Boston board support

 configure                            |   8 +-
 default-configs/mips64el-softmmu.mak |   3 +
 dtc                                  |   2 +-
 hw/core/Makefile.objs                |   1 +
 hw/core/loader-fit.c                 | 325 ++++++++++++++++++++
 hw/core/loader.c                     |   7 +-
 hw/intc/mips_gic.c                   |  56 ++--
 hw/mips/Makefile.objs                |   1 +
 hw/mips/boston.c                     | 577 +++++++++++++++++++++++++++++++++++
 hw/misc/mips_cmgcr.c                 |  17 ++
 hw/pci-host/Makefile.objs            |   1 +
 hw/pci-host/xilinx-pcie.c            | 328 ++++++++++++++++++++
 hw/timer/mips_gictimer.c             |   5 +
 include/hw/loader-fit.h              |  41 +++
 include/hw/loader.h                  |   6 +
 include/hw/misc/mips_cmgcr.h         |   3 +
 include/hw/pci-host/xilinx-pcie.h    |  68 +++++
 include/hw/timer/mips_gictimer.h     |   1 +
 target/mips/cpu.h                    |   1 +
 target/mips/translate.c              |  10 +
 20 files changed, 1425 insertions(+), 36 deletions(-)
 create mode 100644 hw/core/loader-fit.c
 create mode 100644 hw/mips/boston.c
 create mode 100644 hw/pci-host/xilinx-pcie.c
 create mode 100644 include/hw/loader-fit.h
 create mode 100644 include/hw/pci-host/xilinx-pcie.h

Comments

Peter Maydell Feb. 23, 2017, 12:46 p.m. UTC | #1
On 22 February 2017 at 00:21, Yongbok Kim <yongbok.kim@imgtec.com> wrote:
> Hi,
>
> This is the v2 of the pull-req for target-mips.
> The warning treated as error has been fixed and the file is now isolated for mips64el only.
> Boston has further update to have default -drive to if=ide.
>
> Regards,
> Yongbok
>
> The following changes since commit 796b288f7be875045670f963ce99991b3c8e96ac:
>
>   Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into staging (2017-02-21 15:48:22 +0000)
>
> are available in the git repository at:
>
>   git://github.com/yongbok/upstream-qemu.git tags/mips-20170222
>
> for you to fetch changes up to d3473e147a754e999718bf6fcb015d9978c6a1ee:
>
>   hw/mips: MIPS Boston board support (2017-02-21 23:49:30 +0000)
>
> ----------------------------------------------------------------
> MIPS patches 2017-02-22
>
> Changes:
> * Add MIPS Boston board support

This seems to cause a lot of new clang sanitizer warnings:
/home/petmay01/linaro/qemu-for-merges/dtc/libfdt/fdt_rw.c:288:21:
runtime error: null pointer passed as argument 2, which is declared to
never be null

which are all for the memcpy() in fdt_setprop() when fdt_setprop()
is passed a NULL pointer.

On the other hand the implementation of fdt_setprop() hasn't changed
in years so I'm not quite sure why this warning is only showing up
now. It may be that the clang build used to pull in system libfdt
but now has built its own.

On that basis I've pushed this to master and we'll figure out
the sanitizer issues separately.

Please make sure you update the 'Build dependencies' section of
http://wiki.qemu-project.org/ChangeLog/2.9
to flag up the new libfdt version dependency to users.

thanks
-- PMM
Peter Maydell March 16, 2017, 3:03 p.m. UTC | #2
On 23 February 2017 at 12:46, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 22 February 2017 at 00:21, Yongbok Kim <yongbok.kim@imgtec.com> wrote:
>> This is the v2 of the pull-req for target-mips.
>> The warning treated as error has been fixed and the file is now isolated for mips64el only.
>> Boston has further update to have default -drive to if=ide.

> Please make sure you update the 'Build dependencies' section of
> http://wiki.qemu-project.org/ChangeLog/2.9
> to flag up the new libfdt version dependency to users

Reminder: please update
http://wiki.qemu-project.org/ChangeLog/2.9#Build_dependencies
to mention the new libfdt version dependency.

thanks
-- PMM
Yongbok Kim March 16, 2017, 4:25 p.m. UTC | #3
I updated the section before?

Build dependencies

    QEMU now requires a minimum dtc version of 1.4.2.

Do you mean to update it like "dtc (libfdt)"?

Regards,
Yongbok


On 16/03/2017 15:03, Peter Maydell wrote:
> On 23 February 2017 at 12:46, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 22 February 2017 at 00:21, Yongbok Kim <yongbok.kim@imgtec.com> wrote:
>>> This is the v2 of the pull-req for target-mips.
>>> The warning treated as error has been fixed and the file is now isolated for mips64el only.
>>> Boston has further update to have default -drive to if=ide.
> 
>> Please make sure you update the 'Build dependencies' section of
>> http://wiki.qemu-project.org/ChangeLog/2.9
>> to flag up the new libfdt version dependency to users
> 
> Reminder: please update
> http://wiki.qemu-project.org/ChangeLog/2.9#Build_dependencies
> to mention the new libfdt version dependency.
> 
> thanks
> -- PMM
>
Peter Maydell March 16, 2017, 4:28 p.m. UTC | #4
On 16 March 2017 at 16:25, Yongbok Kim <yongbok.kim@imgtec.com> wrote:
> I updated the section before?
>
> Build dependencies
>
>     QEMU now requires a minimum dtc version of 1.4.2.
>
> Do you mean to update it like "dtc (libfdt)"?
>

No, that's fine. Sorry, I must have somehow been looking at
a stale version of the page or the wrong copy or something.

thanks
-- PMM