| Message ID | 8bf052e3-de8f-dbdf-be76-369a7bb1ed15@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 02/21/2017 12:18 PM, Heiner Kallweit wrote: > Add clock CLKID_RNG0 to HW randon number generator node and > extend the DT binding documentation accordingly. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > v2: > - splitted first version of patch into two > - add DT binding documentation Hi Heiner, Can you move the dt-bindings to a separate patch ? > - mention that clock is optional > - replace spaces with tabs in DT binding example > --- > Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt | 8 ++++++-- > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ > 3 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt > index 202f2d09..4c012a04 100644 > --- a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt > +++ b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt > @@ -5,10 +5,14 @@ Required properties: > > - compatible : should be "amlogic,meson-rng" > - reg : Specifies base physical address and size of the registers. > +- clocks : Optional core clock > +- clock-names: Name of core clock, must be "core" Please put these in a separate "Optional Properties" : Optional Properties: - clocks : phandle to the following named clocks - clock-names: Name of core clock, must be "core" > > Example: > > rng { > - compatible = "amlogic,meson-rng"; > - reg = <0x0 0xc8834000 0x0 0x4>; > + compatible = "amlogic,meson-rng"; > + reg = <0x0 0xc8834000 0x0 0x4>; > + clocks = <&clkc CLKID_RNG0>; > + clock-names = "core"; > }; > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > index 5d995f77..620495a4 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -380,7 +380,7 @@ > #size-cells = <2>; > ranges = <0x0 0x0 0x0 0xc8834000 0x0 0x2000>; > > - rng { > + hwrng: rng { > compatible = "amlogic,meson-rng"; > reg = <0x0 0x0 0x0 0x4>; > }; > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 04b3324b..a375cb21 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -524,3 +524,8 @@ > &vpu { > compatible = "amlogic,meson-gxbb-vpu", "amlogic,meson-gx-vpu"; > }; > + > +&hwrng { > + clocks = <&clkc CLKID_RNG0>; > + clock-names = "core"; > +}; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 21, 2017 at 09:18:16PM +0100, Heiner Kallweit wrote: > Add clock CLKID_RNG0 to HW randon number generator node and > extend the DT binding documentation accordingly. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > v2: > - splitted first version of patch into two > - add DT binding documentation > - mention that clock is optional > - replace spaces with tabs in DT binding example > --- > Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt | 8 ++++++-- > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ > 3 files changed, 12 insertions(+), 3 deletions(-) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt index 202f2d09..4c012a04 100644 --- a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt +++ b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt @@ -5,10 +5,14 @@ Required properties: - compatible : should be "amlogic,meson-rng" - reg : Specifies base physical address and size of the registers. +- clocks : Optional core clock +- clock-names: Name of core clock, must be "core" Example: rng { - compatible = "amlogic,meson-rng"; - reg = <0x0 0xc8834000 0x0 0x4>; + compatible = "amlogic,meson-rng"; + reg = <0x0 0xc8834000 0x0 0x4>; + clocks = <&clkc CLKID_RNG0>; + clock-names = "core"; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi index 5d995f77..620495a4 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi @@ -380,7 +380,7 @@ #size-cells = <2>; ranges = <0x0 0x0 0x0 0xc8834000 0x0 0x2000>; - rng { + hwrng: rng { compatible = "amlogic,meson-rng"; reg = <0x0 0x0 0x0 0x4>; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index 04b3324b..a375cb21 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -524,3 +524,8 @@ &vpu { compatible = "amlogic,meson-gxbb-vpu", "amlogic,meson-gx-vpu"; }; + +&hwrng { + clocks = <&clkc CLKID_RNG0>; + clock-names = "core"; +};
Add clock CLKID_RNG0 to HW randon number generator node and extend the DT binding documentation accordingly. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- v2: - splitted first version of patch into two - add DT binding documentation - mention that clock is optional - replace spaces with tabs in DT binding example --- Documentation/devicetree/bindings/rng/amlogic,meson-rng.txt | 8 ++++++-- arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++ 3 files changed, 12 insertions(+), 3 deletions(-)