| Message ID | 1487680479-15132-1-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PULL 00/11] Changes to -drive without if= and with if=scsi
Message-id: 1487680479-15132-1-git-send-email-armbru@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1486531462-13882-1-git-send-email-zhangchen.fnst@cn.fujitsu.com -> patchew/1486531462-13882-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
* [new tag] patchew/1487680479-15132-1-git-send-email-armbru@redhat.com -> patchew/1487680479-15132-1-git-send-email-armbru@redhat.com
* [new tag] patchew/1487682332-29154-1-git-send-email-kraxel@redhat.com -> patchew/1487682332-29154-1-git-send-email-kraxel@redhat.com
Switched to a new branch 'test'
8bfef42 hw/i386: Deprecate -drive if=scsi with PC machine types
7638d3f hw: Deprecate -drive if=scsi with non-onboard HBAs
dc17149 hw/scsi: Concentrate -drive if=scsi auto-create in one place
6196006 hw: Drop superfluous special checks for orphaned -drive
3d87f86 blockdev: Make orphaned -drive fatal
a7472ca blockdev: Improve message for orphaned -drive
781e308 hw/arm/highbank: Default -drive to if=ide instead of if=scsi
04b725b hw: Default -drive to if=none instead of scsi when scsi cannot work
cecd7a2 hw: Default -drive to if=none instead of ide when ide cannot work
027c597 hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus
ccfec9e hw: Default -drive to if=ide explicitly where it works
=== OUTPUT BEGIN ===
Checking PATCH 1/11: hw: Default -drive to if=ide explicitly where it works...
Checking PATCH 2/11: hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus...
Checking PATCH 3/11: hw: Default -drive to if=none instead of ide when ide cannot work...
Checking PATCH 4/11: hw: Default -drive to if=none instead of scsi when scsi cannot work...
Checking PATCH 5/11: hw/arm/highbank: Default -drive to if=ide instead of if=scsi...
Checking PATCH 6/11: blockdev: Improve message for orphaned -drive...
Checking PATCH 7/11: blockdev: Make orphaned -drive fatal...
Checking PATCH 8/11: hw: Drop superfluous special checks for orphaned -drive...
Checking PATCH 9/11: hw/scsi: Concentrate -drive if=scsi auto-create in one place...
Checking PATCH 10/11: hw: Deprecate -drive if=scsi with non-onboard HBAs...
Checking PATCH 11/11: hw/i386: Deprecate -drive if=scsi with PC machine types...
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#72: FILE: tests/qemu-iotests/051.pc.out:122:
+q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
^
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#92: FILE: tests/qemu-iotests/051.pc.out:178:
+q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
^
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#102: FILE: tests/qemu-iotests/051.pc.out:188:
+q[K[Dqu[K[D[Dqui[K[D[D[Dquit[K
^
total: 3 errors, 0 warnings, 63 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 21 February 2017 at 12:34, Markus Armbruster <armbru@redhat.com> wrote: > The following changes since commit b856256179f14c33a513d0b9cc3e4be355b95f43: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20170221-1' into staging (2017-02-21 09:35:15 +0000) > > are available in the git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-block-2017-02-21 > > for you to fetch changes up to f778a82f0c179634892ea716970d4d35264dc841: > > hw/i386: Deprecate -drive if=scsi with PC machine types (2017-02-21 13:17:45 +0100) > > ---------------------------------------------------------------- > Changes to -drive without if= and with if=scsi > > ---------------------------------------------------------------- > Markus Armbruster (11): > hw: Default -drive to if=ide explicitly where it works > hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus > hw: Default -drive to if=none instead of ide when ide cannot work > hw: Default -drive to if=none instead of scsi when scsi cannot work > hw/arm/highbank: Default -drive to if=ide instead of if=scsi > blockdev: Improve message for orphaned -drive > blockdev: Make orphaned -drive fatal > hw: Drop superfluous special checks for orphaned -drive > hw/scsi: Concentrate -drive if=scsi auto-create in one place > hw: Deprecate -drive if=scsi with non-onboard HBAs > hw/i386: Deprecate -drive if=scsi with PC machine types Applied, thanks. -- PMM
The following changes since commit b856256179f14c33a513d0b9cc3e4be355b95f43: Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20170221-1' into staging (2017-02-21 09:35:15 +0000) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-block-2017-02-21 for you to fetch changes up to f778a82f0c179634892ea716970d4d35264dc841: hw/i386: Deprecate -drive if=scsi with PC machine types (2017-02-21 13:17:45 +0100) ---------------------------------------------------------------- Changes to -drive without if= and with if=scsi ---------------------------------------------------------------- Markus Armbruster (11): hw: Default -drive to if=ide explicitly where it works hw/arm/cubieboard hw/arm/xlnx-ep108: Fix units_per_default_bus hw: Default -drive to if=none instead of ide when ide cannot work hw: Default -drive to if=none instead of scsi when scsi cannot work hw/arm/highbank: Default -drive to if=ide instead of if=scsi blockdev: Improve message for orphaned -drive blockdev: Make orphaned -drive fatal hw: Drop superfluous special checks for orphaned -drive hw/scsi: Concentrate -drive if=scsi auto-create in one place hw: Deprecate -drive if=scsi with non-onboard HBAs hw/i386: Deprecate -drive if=scsi with PC machine types blockdev.c | 23 ++++++++++-------- hw/alpha/dp264.c | 1 + hw/arm/cubieboard.c | 4 ++++ hw/arm/highbank.c | 8 +++++-- hw/arm/realview.c | 3 +-- hw/arm/spitz.c | 3 +++ hw/arm/tosa.c | 1 + hw/arm/versatilepb.c | 2 +- hw/arm/vexpress.c | 1 - hw/arm/xilinx_zynq.c | 1 - hw/arm/xlnx-ep108.c | 6 +++++ hw/i386/pc.c | 7 ++++++ hw/ide/core.c | 17 ------------- hw/mips/mips_fulong2e.c | 1 + hw/mips/mips_jazz.c | 4 ---- hw/mips/mips_malta.c | 1 + hw/mips/mips_r4k.c | 1 + hw/ppc/mac_newworld.c | 1 + hw/ppc/mac_oldworld.c | 1 + hw/ppc/prep.c | 1 + hw/scsi/esp-pci.c | 3 --- hw/scsi/esp.c | 6 ----- hw/scsi/lsi53c895a.c | 10 +++++--- hw/scsi/megasas.c | 4 ---- hw/scsi/mptsas.c | 4 ---- hw/scsi/scsi-bus.c | 56 +++++++++++++++++++++++++++++++++++++------ hw/scsi/spapr_vscsi.c | 5 ++-- hw/scsi/virtio-scsi.c | 8 ------- hw/sh4/r2d.c | 1 + hw/sparc/sun4m.c | 5 ---- hw/sparc64/sun4u.c | 2 ++ include/hw/pci/pci.h | 2 ++ include/hw/scsi/scsi.h | 3 ++- include/sysemu/blockdev.h | 11 ++++----- qemu-options.hx | 5 ---- tests/qemu-iotests/051.pc.out | 12 ++++++---- vl.c | 10 ++++++++ 37 files changed, 137 insertions(+), 97 deletions(-)