NX: Encryption is not supported with NX crypto on Power0

Submitted by Haren Myneni on Feb. 20, 2017, 5:52 a.m.

Details

Message ID 1487569931.5897.15.camel@hbabu-laptop
State Superseded
Headers show

Commit Message

Haren Myneni Feb. 20, 2017, 5:52 a.m.
NX crypto will not be used for encryption on P9 due to performance
issues.

Signed-off-by: Haren Myneni <haren@us.ibm.com>
---
 hw/nx-crypto.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Comments

Benjamin Herrenschmidt Feb. 20, 2017, 5:53 a.m.
On Sun, 2017-02-19 at 21:52 -0800, Haren Myneni wrote:
> +       } else if (dt_node_is_compatible(node, "ibm,power9-nx")) {
> +               prlog(PR_INFO, "NX: Encryption is not supported with
> "
> +                               "NX crypto on P9\n");
> +               return;
>         } else {

Don't print anything.
Haren Myneni Feb. 20, 2017, 6:37 a.m.
On 02/19/2017 09:53 PM, Benjamin Herrenschmidt wrote:
> On Sun, 2017-02-19 at 21:52 -0800, Haren Myneni wrote:
>> +       } else if (dt_node_is_compatible(node, "ibm,power9-nx")) {
>> +               prlog(PR_INFO, "NX: Encryption is not supported with
>> "
>> +                               "NX crypto on P9\n");
>> +               return;
>>         } else {
> 
> Don't print anything.
> 
Thanks Ben, will remove it.

Patch hide | download patch | download mbox

diff --git a/hw/nx-crypto.c b/hw/nx-crypto.c
index 723c571..48fc24d 100644
--- a/hw/nx-crypto.c
+++ b/hw/nx-crypto.c
@@ -265,6 +265,10 @@  void nx_create_crypto_node(struct dt_node *node)
 		cfg_asym = pb_base + NX_P8_ASYM_CFG;
 		cfg_iq = pb_base + NX_P8_CRB_IQ;
 		cfg_ee = pb_base + NX_P8_EE_CFG;
+	} else if (dt_node_is_compatible(node, "ibm,power9-nx")) {
+		prlog(PR_INFO, "NX: Encryption is not supported with "
+				"NX crypto on P9\n");
+		return;
 	} else {
 		prerror("NX%d: ERROR: Unknown NX type!\n", gcid);
 		return;