Message ID | 9dfb70bb6d3f7930a48f6392e05eff6892feb5f9.1487590641.git.pavel.belous@aquantia.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vRhb43whlz9ryk for <patchwork-incoming@ozlabs.org>; Mon, 20 Feb 2017 22:43:12 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="pwb1F28/"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752999AbdBTLnK (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Mon, 20 Feb 2017 06:43:10 -0500 Received: from mail-by2nam03on0086.outbound.protection.outlook.com ([104.47.42.86]:47808 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752854AbdBTLnE (ORCPT <rfc822;netdev@vger.kernel.org>); Mon, 20 Feb 2017 06:43:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yC3Tft8+0NTU9Owq74hJlsnCQjbHlBOnXs3iBv3kR9A=; b=pwb1F28/lWY7fuMVgvBmNpWmkZVX1JB1reiil/C27DXZgbWDIlidtYoBFIq3WfRftwctHCmFQrFNRz9rpRK1k8CLiBzQo7wC04EP9RBIc8wpMwhggXqOWGa5Vq/UxRvHQBbKPlOnWX31sbump+KFRFw687fo3ENq0wDA/M51vR4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavel.Belous@aquantia.com; Received: from atltest07.rdc.aquantia.com (83.149.43.106) by CY1PR07MB2299.namprd07.prod.outlook.com (10.166.194.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Mon, 20 Feb 2017 11:42:57 +0000 From: Pavel Belous <Pavel.Belous@aquantia.com> To: "David S . Miller" <davem@davemloft.net> Cc: netdev@vger.kernel.org, Simon Edelhaus <Simon.Edelhaus@aquantia.com>, Alexey Andriyanov <Alexey.Andriyanov@aquantia.com>, Lino Sanfilippo <LinoSanfilippo@gmx.de>, Pavel Belous <pavel.belous@aquantia.com> Subject: [PATCH net-next v3 08/12] net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc. Date: Mon, 20 Feb 2017 14:41:50 +0300 Message-Id: <9dfb70bb6d3f7930a48f6392e05eff6892feb5f9.1487590641.git.pavel.belous@aquantia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <cover.1487590641.git.pavel.belous@aquantia.com> References: <cover.1487590641.git.pavel.belous@aquantia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [83.149.43.106] X-ClientProxiedBy: VI1PR07CA0064.eurprd07.prod.outlook.com (10.164.94.160) To CY1PR07MB2299.namprd07.prod.outlook.com (10.166.194.28) X-MS-Office365-Filtering-Correlation-Id: 3daebfb5-1d56-4d64-f5aa-08d459859e82 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR07MB2299; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2299; 3:YGP0n5hBk3NP7QrIrKXX+7thOJVk+4Mu/zTToM7bc1Fi2Ar0l3TGq9ahTVkGikxCG8dx4BiliVzQ8WDGNnQUUCCaEJxlRl7U4GjTl54sZLLgP1EuqKsZAGMhrMk4d5Gmf1KhJFBrOmGggXVteT1CYIx1qJNlpgH/Q3Qlge0udG9Pq5zqfsChKVPC0VMjkQXLlCeasL2A6DIKlESZBRhYdKpt29et3XdTNqX7ocp/uSgA4kSYkVIvA25za1RYnXDpGG2YtVMgfWTKimrhrktGfA==; 25:9caRl72v7LWKsT4bu1+oZ0it0wWwdtKTmGtHxriJ2ScFriCkQrHPJB7AHnGor3GLEZZsC0r04ABoaZ0t3d+0WJ1xaRjaikcf0XSnHSGS2NjpfgijfIX/smwSLJwhd7cmgGXpLWGkIQTxPmIv88onnZ6YQQglGWz2mPkg74jfkur4oCao1laFtgzfqtZbWOFgvvad2m0hWC9NE32Df/+c6vsUPyXfEYyheNvrrm+Uc0lk5+WbalqkuP8MjhOig58a9DYW2hfbz/d1szAdInMcXPr66TCNO179/79DUmdQSBJZltsPTPoGdU7v0XunFIs5FSePTFnIekf6SiPlUKVHJRN1qrWB9UPD0vhbgP8sTDpLNIfjC70hYLIRlwI0o4rTchjgUtemHij5emglW1MPREUsrkBbSZ/fDttsvFyDv5pSw4Pqq4xIyjSRbiO1eAIjfzUzPMaqKAsQpD3S3Uog7A== X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2299; 31:2VFSoKloU9Z/M+Q6+aRotqDCb74y405TEJoVH7FwLJvcFpOYFIOdST4OyAO2OYljAd8PO1MLrN948eFcZ5ERo/9QAk9QVBOb+BOJ7+cirJY/PrP6NB8q2ow/seMN0PMMciZf0/BjNBgZ/oh9sBnrryzeY7dQf+SCgvCYwXulQbe/5Ta2VCxNMIJRCm9wGGCR9mHn++REaNAC6uOyYI1p4sBX0cSh7dlcZRpOQxT7Hio=; 20:sDAKion5MKJTqjhXXCp+IeQ8q2l0wrczAiDr6aEM6PR/me5oOKCiMDzYdGNHsbL23GeSJ+1nJOGe+r65ZKLeu+IPoN5zkDLjzkYxqZBZFmj2oeQYsE5dHi6Qy4WFgxDrxsdjEDoKuqKsTVXxM3glF9ycJKpJHkWMUkZTUoLyETJNECPV1Wu4lP9KTbjZMkI3E5rwd5iK4Pwl8zGctcBxVs1xKTk1jfjcnLoVhPwRHy6OURjzExS8Ay/cN2o/tPs9FSlOPI7v6ZOmRtdMKjU6SbiQlI+owfdeWn6zB7ep1Zg7ecOeo5fmvnB8MSNJjDS3q3qjkThIgGBvQJmPfP0rmqFyhXw5/xrnA+ipzsgJZmGa2z1BbSrhSQfe1tnLtqfAA+C9WHrNdRX9nnM383MdtpcH38Ls96EG4h0I3uTUxT9QDIzK5w0kXtTYpx1EQ05B8zu8SQ/EzUGqPZxk/v7t6bEUwz4qRQQ3K7uh1EC/a5FDARWui43aFgJvLwR4zKXg X-Microsoft-Antispam-PRVS: <CY1PR07MB2299E191B4BFFABE0ECC9BB0E15E0@CY1PR07MB2299.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(26323138287068); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558025)(6072148); SRVR:CY1PR07MB2299; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2299; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2299; 4:c1Y1AzzO8X4v2bxN1bAA1WlSMf8Zd48mAH00YO7i2dLdtZp0eFbN6bIHGKxvB38HKT1ZXqBJltmBW/c7i24pr9Im4GvprtnV47qNzFaMxT9KRJwEcuVm53exzc5/FBbiFemwDhRCjnZxWE/X/3q+x6J5KCpgX2jGyLg5bQCGXWSKMxsWOUMAtdw/asGP9lS6ItMOheCvJLP44ImhNcqldLPtd0ZRaz+ft2n5WJR3fdnSvdT7zCRRNs5ipJ3dhMUzebxzWKotbq64bxzz/rQgQaHOoK78avCSvAgsKYeUPWLmELutS6z10kBQ6Mj6DcVhkwMgGe8nJkDzXwFr5xMmhKJXQHnw87Xhk6/OPCqX6wGRDNsRgqCP1uQnChniptlU+AJOHpYw/f77yXSyEOVvf2yJ6nlsyJhBKLNLf9b4rteTUwIqmYQWikJNsua6HEGqAH+V3STPHZtEO/SlREXNjMt8aMPN+CvGc2ow/NAnWFCiGxJZylQsMdo5JDYl+w++czWXUKTsvvcWk8dSR57koNK9MOIYIyq8R4mc9ISClpWqPDyPggFgdS0c+N2pgbXEuZwzLSpkvjSTlqBdf7jKPYoFPyCbsCQMhgZ942Y/IRaAGbWs4VTA0xn+ADpF4/F0XhBqWeJSpUHvuUlWt4m58Q== X-Forefront-PRVS: 02243C58C6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(199003)(189002)(50986999)(76176999)(92566002)(2906002)(36756003)(66066001)(305945005)(5660300001)(42186005)(68736007)(5003940100001)(7736002)(6486002)(38730400002)(118296001)(105586002)(4326007)(101416001)(110136004)(107886003)(81166006)(47776003)(6666003)(2950100002)(6916009)(8676002)(50226002)(106356001)(53936002)(25786008)(8666007)(189998001)(54906002)(81156014)(6116002)(48376002)(97736004)(50466002)(3846002)(33646002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2299; H:atltest07.rdc.aquantia.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2299; 23:4MortxHEpJP4351nq+HySKyZbId/MF7WzA3c0sC5P?= =?us-ascii?Q?4dh6uxOzcdZqjorkMAXC3pRkfAyHoQdQX1q0n6RPCMiowPxWuhmgY4kF01pp?= =?us-ascii?Q?LpMa4dlVJdAEvwnMRQcdHqyGQj6xsjSYL9oMExHhIJl2GTmwjmBDXbeHsISO?= =?us-ascii?Q?LSwBucW5KPzc9IXOm7mabAp5rfYsgQrb9NqpEbis+c8eanjeQHdhAh7SW1JP?= =?us-ascii?Q?DqsbSdKgcoE/DkZEiz3cnqN67FWfGb3HuF+RwNa/fiyqtMhGgSAxZhaaCJ8v?= =?us-ascii?Q?xysUnUPhouRezKaE3IhwAdCXhZQfoj+CtU/eWoLyvSi8YxJtF0T3NrtmhGOG?= =?us-ascii?Q?7d0BPAaiIQRupMEohshOfI12ZTfZQf5rZP0tS+b1m0gkWaYGrEMs7/fMK6j3?= =?us-ascii?Q?3gK5yqgIKSaeMo4G/ZggZdRDCZ0BBrpH35CPWJ8FPKJ3fvrBpizHQjsfd1kl?= =?us-ascii?Q?do+YXDFOEdVqtHJmm6M2o7EgU+Ns3KztrXuSHTUTzklgBXo7dtkXgVMEvUuK?= =?us-ascii?Q?a1DOgPXI3EVHsWfD3wMbKDywXZoU6lhMhDzy3okwsBxDUibOZ4O8Fsvpr0VR?= =?us-ascii?Q?PNkEQJ90WdmWvOZCszivi4ujiLWJXjqys9pMELTi7xc0JzupXf3JsZRfyAK7?= =?us-ascii?Q?HP2HVvE8LtRY08y6hbV9E78PdYvEZTzzvBlI83MAdlIU4zXpLhfLolKTs8gw?= =?us-ascii?Q?hISlEqzXneG8y+POpz6QbjQZdLphPanMstCiPQUCZ9JaDHPbm4dnQD+Nt05d?= =?us-ascii?Q?Y0JLBw0p5N0xfMsQdTeV1ds0PjlbKm1L+hVTYZrxFAds6fJx8hhUG2HSvHKF?= =?us-ascii?Q?Gp4swBP9+uXlEn9Z0AvPVOLvB5SsudgsnEHUUquBmIt5DOqy9r1LcyLGXwnJ?= =?us-ascii?Q?lx6C0eNkyTU1ECHwebkZM+TFpq7ifIcs9pV3XyWD+TULCEWhU5jQ36KUmPXc?= =?us-ascii?Q?S2SGULIBA2AOeaWUpCcZyQmK0AbgqJPSNkl9hcXvhTYdl5VnVHB5Gtlyg3Ve?= =?us-ascii?Q?QMGYFXrOmJgV3zvaDvkViTmJ2as5yziaD7MB4JMhSP97GiijH9tJf9sL2Ije?= =?us-ascii?Q?FeYYt7nr+kumvutxT7dGrwl9d/0xdIrPHFrPwyioqR+BxX005rw/kxIAu2qN?= =?us-ascii?Q?Lpc7jf66HJ3WFNoQ8agoRstdLDYSbr4?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2299; 6:iS0BmIP2Lrn+VbBsfMYEMR3a1WHTVgmMRiOM77nAFZDpwwWemoqFk3fdhRj3kR4W1i8UKvbHT89ImLRyg2ReOeeGbiK+QJdo5jQlJr0MOsusE6WxzXqH0FkFqPhZR+ItavN41hrS/6xydournpXK7AsmLGTYUFmx68V7+gl7FiPxsenVKGihl4/Aq0g2+cpMT/dRerhzZwHEAPmbEop7Di1yHlEO6zoDi6iCf3pcVVeDJRJNA7D4SL7kKq8GnqcBk2MvExKIlswIAMEhx770/PPUU6QseTDFli/fMe6BPhT07pefaSvQQYS70XYMKvHaUbH5ocpxxyAYNoQWU1wMQ2dxPztKdZEpU4XpaGA40qIJl+tV0Yvx0jgqpGpmDPUxPhhyk+Ujs7rzNUWRzLnaUA==; 5:fR87NC+MSS1wjHWBHAIUXlpWdMt4+7dItpX1wsGaam486AUK5ED0oWYF3OIF50zGL7JAbbkWJyT21dUpgs0p6GqEFOfAllkNytdYU39XcRY2IkJljrQU530F967faCroMHmcJhQ9sOYcshJlJwq/zO77YcBZDN1O+TBbJ7Ir+kw=; 24:LLR6Sm5FO3hPO/gMkREeV+5IJAtBjEUJ0gsOYwxjRZBeyI3bBpGAqowcvQ45ACGzRsxxxu9wIg2abdakl7bNW+vPY5/ceYoTaRseGtXz2Bg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2299; 7:2wKBGMnYqS1ex/ZEWpfqSnXch2Bdx3SyfeqKrnStXDlf3we3wHueURn1vdk+N582kVqoUD60EyACknMYnPv6b/lioj4j4I10lcKC+9SnivygtpsplPI42Dc2o20zR2viykzWCBh0hKR8IlDRZ74TtjENlnS7o3GN2TfP0VOkIqkxV6Zs9eK0h1L2R1mBFGXFjT6N29yE7bTfAgcu9eVQCZ8p1f1AItVYjtdwC1N14U7euWsbub8oPL+dtakb7RgUgdFF8F8fXkqIiPsKTtzQxfxD7STdzLVQQDWBcfnpGW9d8P6pMzrmXTJKiCsHkE4GXwdA4Zg4KLxG/yVupbkEqA== X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2017 11:42:57.1611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2299 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index 019bcc7..a8a27c5 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -202,12 +202,13 @@ struct aq_nic_s *aq_nic_alloc_cold(const struct net_device_ops *ndev_ops, int err = 0; ndev = aq_nic_ndev_alloc(); - self = netdev_priv(ndev); - if (!self) { - err = -EINVAL; + if (!ndev) { + err = -ENOMEM; goto err_exit; } + self = netdev_priv(ndev); + ndev->netdev_ops = ndev_ops; ndev->ethtool_ops = et_ops;