diff mbox

directfb: add gfx-state initialisation

Message ID 2c18997f-f4da-4ed8-afd6-b9e7e1c6e4ad@EXDRUEARSGC008.eq1sgc.local
State Accepted
Headers show

Commit Message

Philippe Reynes Feb. 20, 2017, 10:31 a.m. UTC 
The patch 0006-fix-client-gfx_state-initialisation.patch
add the initialisation for the variable gfx-state.

This patch was provided by the community and it is already
integrated in OpenEmbedded.

Signed-off-by: Philippe Reynes <philippe.reynes@sagemcom.com>
---
 .../0006-fix-client-gfx_state-initialisation.patch |   38 ++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/directfb/0006-fix-client-gfx_state-initialisation.patch

Comments

Thomas Petazzoni Feb. 20, 2017, 8:37 p.m. UTC | #1 
Hello,

On Mon, 20 Feb 2017 11:31:24 +0100, Philippe Reynes wrote:
> The patch 0006-fix-client-gfx_state-initialisation.patch
> add the initialisation for the variable gfx-state.
> 
> This patch was provided by the community and it is already
> integrated in OpenEmbedded.
> 
> Signed-off-by: Philippe Reynes <philippe.reynes@sagemcom.com>
> ---
>  .../0006-fix-client-gfx_state-initialisation.patch |   38 ++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 package/directfb/0006-fix-client-gfx_state-initialisation.patch

Applied to master, thanks.

Thomas
diff mbox

Patch

diff --git a/package/directfb/0006-fix-client-gfx_state-initialisation.patch b/package/directfb/0006-fix-client-gfx_state-initialisation.patch
new file mode 100644
index 0000000..57a9b0d
--- /dev/null
+++ b/package/directfb/0006-fix-client-gfx_state-initialisation.patch
@@ -0,0 +1,38 @@ 
+From 8e53c0b9cedb62b82e2b7680d793d433b647ae20 Mon Sep 17 00:00:00 2001
+From: Andre McCurdy <armccurdy@gmail.com>
+Date: Mon, 13 Jun 2016 13:32:44 -0700
+Subject: [PATCH] fix client->gfx_state initialisation
+
+Shortly before the DirectFB 1.7.7 release, an optimisation was added
+to CoreGraphicsStateClient_Init() to avoid creating an extended
+Graphics State object if it will not later be required:
+
+  4d422fb Client: Create extended Graphics State object when needed for later usage
+
+Unfortunately the client->gfx_state variable used to track the
+extended Graphics State object is not initialised, which can lead to
+crashes etc due to creation of the Graphics State object erroneously
+being skipped.
+
+Upstream-Status: Pending
+
+Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
+---
+ src/core/CoreGraphicsStateClient.cpp | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/core/CoreGraphicsStateClient.cpp b/src/core/CoreGraphicsStateClient.cpp
+index 5d46f0e..5007755 100644
+--- a/src/core/CoreGraphicsStateClient.cpp
++++ b/src/core/CoreGraphicsStateClient.cpp
+@@ -364,6 +364,7 @@ CoreGraphicsStateClient_Init( CoreGraphicsStateClient *client,
+      client->renderer  = NULL;
+      client->requestor = NULL;
+      client->throttle  = NULL;
++     client->gfx_state = NULL;
+ 
+      if (dfb_config->task_manager) {
+           if (dfb_config->call_nodirect) {
+-- 
+1.9.1
+