| Message ID | 1487499469-15284-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Sun, Feb 19, 2017 at 03:47:49PM +0530, Aneesh Kumar K.V wrote: > With this we have on powernv and pseries /proc/cpuinfo reporting > > timebase : 512000000 > platform : PowerNV > model : 8247-22L > machine : PowerNV 8247-22L > firmware : OPAL > translation : Hash > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > --- Acked-by: Balbir Singh <bsingharora@gmail.com>
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes: > With this we have on powernv and pseries /proc/cpuinfo reporting > > timebase : 512000000 > platform : PowerNV > model : 8247-22L > machine : PowerNV 8247-22L > firmware : OPAL > translation : Hash > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > --- > arch/powerpc/platforms/powernv/setup.c | 4 ++++ > arch/powerpc/platforms/pseries/setup.c | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c > index d50c7d99baaf..d38571e289bb 100644 > --- a/arch/powerpc/platforms/powernv/setup.c > +++ b/arch/powerpc/platforms/powernv/setup.c > @@ -95,6 +95,10 @@ static void pnv_show_cpuinfo(struct seq_file *m) > else > seq_printf(m, "firmware\t: BML\n"); > of_node_put(root); > + if (radix_enabled()) > + seq_printf(m, "translation\t: Radix\n"); > + else > + seq_printf(m, "translation\t: Hash\n"); > } Can we just call it "MMU" ? I don't think it's entirely clear what "translation" means here if you don't already know. cheers
On Wednesday 22 February 2017 11:15 AM, Michael Ellerman wrote: > "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes: > >> With this we have on powernv and pseries /proc/cpuinfo reporting >> >> timebase : 512000000 >> platform : PowerNV >> model : 8247-22L >> machine : PowerNV 8247-22L >> firmware : OPAL >> translation : Hash >> >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> >> --- >> arch/powerpc/platforms/powernv/setup.c | 4 ++++ >> arch/powerpc/platforms/pseries/setup.c | 4 ++++ >> 2 files changed, 8 insertions(+) >> >> diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c >> index d50c7d99baaf..d38571e289bb 100644 >> --- a/arch/powerpc/platforms/powernv/setup.c >> +++ b/arch/powerpc/platforms/powernv/setup.c >> @@ -95,6 +95,10 @@ static void pnv_show_cpuinfo(struct seq_file *m) >> else >> seq_printf(m, "firmware\t: BML\n"); >> of_node_put(root); >> + if (radix_enabled()) >> + seq_printf(m, "translation\t: Radix\n"); >> + else >> + seq_printf(m, "translation\t: Hash\n"); >> } > Can we just call it "MMU" ? > > I don't think it's entirely clear what "translation" means here if you > don't already know. > > cheers > I avoided using MMU, because it will confuse hardware guys. Radix is not clearly the full definition of Memory management unit, but rather the translation mode used by memory management unit. But i don't have strong opinion on this. Do you want me to send an updated patch ? or you can update it when you apply it to your tree ? -aneesh
On Wed, 2017-02-22 at 11:19 +0530, Aneesh Kumar K.V wrote: > I avoided using MMU, because it will confuse hardware guys. Why would it ? I don't see how anybody would be confused. And they aren't the primary consumers of /proc/cpuinfo anyway. I agree with Michal here. > Radix is not > clearly the full definition of > Memory management unit, but rather the translation mode used by memory > management unit. But > i don't have strong opinion on this. Who cares ? People understand :-) If you want call it "MMU Mode: if you think it's cleared but I don't like too much having a space on the left in case of stupid parsers... > Do you want me to send an updated patch ? or you can update it when you > apply it to your tree ? > > -aneesh
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes: > On Wednesday 22 February 2017 11:15 AM, Michael Ellerman wrote: >> "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes: >>> diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c >>> index d50c7d99baaf..d38571e289bb 100644 >>> --- a/arch/powerpc/platforms/powernv/setup.c >>> +++ b/arch/powerpc/platforms/powernv/setup.c >>> @@ -95,6 +95,10 @@ static void pnv_show_cpuinfo(struct seq_file *m) >>> else >>> seq_printf(m, "firmware\t: BML\n"); >>> of_node_put(root); >>> + if (radix_enabled()) >>> + seq_printf(m, "translation\t: Radix\n"); >>> + else >>> + seq_printf(m, "translation\t: Hash\n"); >>> } >> Can we just call it "MMU" ? ... > > Do you want me to send an updated patch ? or you can update it when you > apply it to your tree ? I'll fix it up. cheers
diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c index d50c7d99baaf..d38571e289bb 100644 --- a/arch/powerpc/platforms/powernv/setup.c +++ b/arch/powerpc/platforms/powernv/setup.c @@ -95,6 +95,10 @@ static void pnv_show_cpuinfo(struct seq_file *m) else seq_printf(m, "firmware\t: BML\n"); of_node_put(root); + if (radix_enabled()) + seq_printf(m, "translation\t: Radix\n"); + else + seq_printf(m, "translation\t: Hash\n"); } static void pnv_prepare_going_down(void) diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index 7736352f7279..6576fe306561 100644 --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c @@ -86,6 +86,10 @@ static void pSeries_show_cpuinfo(struct seq_file *m) model = of_get_property(root, "model", NULL); seq_printf(m, "machine\t\t: CHRP %s\n", model); of_node_put(root); + if (radix_enabled()) + seq_printf(m, "translation\t: Radix\n"); + else + seq_printf(m, "translation\t: Hash\n"); } /* Initialize firmware assisted non-maskable interrupts if
With this we have on powernv and pseries /proc/cpuinfo reporting timebase : 512000000 platform : PowerNV model : 8247-22L machine : PowerNV 8247-22L firmware : OPAL translation : Hash Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> --- arch/powerpc/platforms/powernv/setup.c | 4 ++++ arch/powerpc/platforms/pseries/setup.c | 4 ++++ 2 files changed, 8 insertions(+)